-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Randomly pick one color for each event written to file (jamp2 handling) #402
Comments
Full details are given in #404. This is on the critical path to get unweighted event sets to the experiments where each event has one color index (but it should not be needed for cross section calculations) |
As I mentioned in oliviermattelaer/mg5amc_test#14 (comment), I would like to go about this issue in two steps:
|
About the design of the dummy algorithm, I am having a look at addmothers.f
In my Fortran patch, I will therefore for the moment assume that JAMP2(0) is equal to parameter NCOLOR. (Suggestion: if this is the case, it would be better to specify this in the Fortran code, rather than relying on code generation to fill the same numerical value).
I should therefore be able to realtively easily design a dummy algorithm... |
… is not called (dummy random choice of color madgraph5#402) This is a WORKAROUND for "Error: failed to reduce to color indices" oliviermattelaer/mg5amc_test#14 Note: in this patch I only set JAMP2(0), while all other JAMP2(1:NCOLOR) are zero. It seems that addmothers.f already has a workaround to cover this case.
… is not called (dummy random choice of color madgraph5#402) This is a WORKAROUND for "Error: failed to reduce to color indices" oliviermattelaer/mg5amc_test#14 Note: in this patch I only set JAMP2(0), while all other JAMP2(1:NCOLOR) are zero. It seems that addmothers.f already has a workaround to cover this case.
I have implemented the first step, a 'dummy' choice of color, in #489. This provides the workarund for oliviermattelaer/mg5amc_test#14 Note that in the end addmothers.f has its own way to set a dummy color, as long as JAMP2(0) is correctly set to NCOLORS, which is the only thing I have done. The next step, doing a real random choice of color, will be more complex... |
…k that events.lhe files are identical in fortran and cuda/cpp (except for random color and helicity madgraph5#402 madgraph5#403)
note that oliviermattelaer/mg5amc_test#24
|
…MLM and --nopatch
…_dsig1.f, auto_dsig.f, matrix1.f This commit formally merges my "patches" and Olivier's color/helicity changes in these three files (the only three files affected by Olivier's changes) BUT I am still missing all of my other "patches"
…three files auto_dsig1.f, auto_dsig.f, matrix1.f
…MLM and all patches, EXCEPT the three files auto_dsig1.f, auto_dsig.f, matrix1.f
… to the three files auto_dsig1.f, auto_dsig.f, matrix1.f cd gg_tt.mad/SubProcesses/P1_gg_ttx/ git checkout 3ad6a11 auto_dsig.f auto_dsig1.f matrix1.f This formally completes the merge of Olivier's changes and my patches, but I have not tried to build yet!
… also reenable all patches in patchMad.sh ./CODEGEN/generateAndCompare.sh gg_tt --mad --nopatch git diff --no-ext-diff -R gg_tt.mad/Source/dsample.f gg_tt.mad/Source/genps.inc gg_tt.mad/SubProcesses/addmothers.f gg_tt.mad/SubProcesses/cuts.f gg_tt.mad/SubProcesses/makefile gg_tt.mad/SubProcesses/reweight.f > CODEGEN/MG5aMC_patches/PROD/patch.common git diff --no-ext-diff -R gg_tt.mad/SubProcesses/P1_gg_ttx/auto_dsig.f gg_tt.mad/SubProcesses/P1_gg_ttx/driver.f gg_tt.mad/SubProcesses/P1_gg_ttx/matrix1.f > CODEGEN/MG5aMC_patches/PROD/patch.P1 git diff --no-ext-diff -R gg_tt.mad/SubProcesses/P1_gg_ttx/auto_dsig1.f > CODEGEN/MG5aMC_patches/PROD/patch.auto_dsig1.f git checkout gg_tt.mad
…aph5#403 (Also add the same line for color choice madgraph5#402, but keep it commented out for now)
…aph5#403 (Also add the same line for color choice madgraph5#402, but keep it commented out for now)
…remain 0 (no lhe files! madgraph5#403 madgraph5#402)
This is in progress. I have some agorithm but it gives me different results from Fortran and C++ (the last two columns). Maybe not ideal to use gg_tt for debugging as it has only two colors...
|
…olor choice madgraph5#402, also try to simplify nParity ifdefs
…or (inline in sigmaKin, remove select_color) NB does not build because it is missing the isLeadingColor function...
…) for leading color selection madgraph5#402
…random choice of color madgraph5#402 in CPPProcess.cc - random color always 1?
…nitialise jamp2_sv for every SIMD page) - OK NOW! Fortran same as C++
There was a silly bug (jamp2_sv not initialised at every SIMD page) in C++. Actually CUDA was already working. Now everything looks good. This is again from BothDebug, comparing MEs, hel and col:
This is implemented in MR #573 (currently WIP). When that is merged, this issue will be closed. |
…r/helicity comparison, all ok!
…NOT needed for vectorised color selection Revert "[lhe] in gg_tt.mad add an int_v typedef for vectorised color selection madgraph5#402" This reverts commit 71565e4.
…sons of Fortran/C++ colors in auto_dsig1.f) ./CODEGEN/generateAndCompare.sh gg_tt --mad --nopatch git diff --no-ext-diff -R gg_tt.mad/Source/dsample.f gg_tt.mad/Source/genps.inc gg_tt.mad/Source/vector.inc gg_tt.mad/SubProcesses/makefile > CODEGEN/MG5aMC_patches/PROD/patch.common git diff --no-ext-diff -R gg_tt.mad/SubProcesses/P1_gg_ttx/auto_dsig1.f gg_tt.mad/SubProcesses/P1_gg_ttx/driver.f gg_tt.mad/SubProcesses/P1_gg_ttx/matrix1.f > CODEGEN/MG5aMC_patches/PROD/patch.P1 git checkout gg_tt.mad
…mps.h (NB: 1MB of source file in ggttggg!)
… it seems to work
…put alltees - finally all ok This completes the random color choice madgraph5#402 This took around 8 hours from 1h to 9h STARTED AT Sun Dec 18 07:32:03 CET 2022 ./tput/teeThroughputX.sh -flt -hrd -makej -eemumu -ggtt -ggttg -ggttgg -ggttggg -makeclean ENDED(1) AT Sun Dec 18 08:39:14 CET 2022 [Status=0] ./tput/teeThroughputX.sh -flt -hrd -makej -eemumu -ggtt -ggttgg -inlonly -makeclean ENDED(2) AT Sun Dec 18 09:00:20 CET 2022 [Status=0] ./tput/teeThroughputX.sh -makej -eemumu -ggtt -ggttg -ggttgg -ggttggg -flt -bridge -makeclean ENDED(3) AT Sun Dec 18 09:09:51 CET 2022 [Status=0] ./tput/teeThroughputX.sh -eemumu -ggtt -ggttgg -flt -rmbhst ENDED(4) AT Sun Dec 18 09:13:28 CET 2022 [Status=0] ./tput/teeThroughputX.sh -eemumu -ggtt -ggttgg -flt -curhst ENDED(5) AT Sun Dec 18 09:17:01 CET 2022 [Status=0]
…put alltees - finally all ok This completes the random color choice madgraph5#402 This took around 8 hours from 1h to 9h STARTED AT Sun Dec 18 07:32:03 CET 2022 ./tput/teeThroughputX.sh -flt -hrd -makej -eemumu -ggtt -ggttg -ggttgg -ggttggg -makeclean ENDED(1) AT Sun Dec 18 08:39:14 CET 2022 [Status=0] ./tput/teeThroughputX.sh -flt -hrd -makej -eemumu -ggtt -ggttgg -inlonly -makeclean ENDED(2) AT Sun Dec 18 09:00:20 CET 2022 [Status=0] ./tput/teeThroughputX.sh -makej -eemumu -ggtt -ggttg -ggttgg -ggttggg -flt -bridge -makeclean ENDED(3) AT Sun Dec 18 09:09:51 CET 2022 [Status=0] ./tput/teeThroughputX.sh -eemumu -ggtt -ggttgg -flt -rmbhst ENDED(4) AT Sun Dec 18 09:13:28 CET 2022 [Status=0] ./tput/teeThroughputX.sh -eemumu -ggtt -ggttgg -flt -curhst ENDED(5) AT Sun Dec 18 09:17:01 CET 2022 [Status=0]
Event by event random choice of one color #402
Randomly pick one color for each event written to file (jamp2 handling)
Will give details elsewhere
The text was updated successfully, but these errors were encountered: