Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review all no 'u'-prefixed string literals #27

Open
ramiro opened this issue Jul 28, 2012 · 1 comment
Open

Review all no 'u'-prefixed string literals #27

ramiro opened this issue Jul 28, 2012 · 1 comment
Assignees

Comments

@ramiro
Copy link

ramiro commented Jul 28, 2012

AFAICT at this point we have the following cases:

  • String literals in modules that weren't touched to add from __future__ import unicode_literals (to fix Remove unicode() calls #25). In that state these literals are byte-buffers on Python2 and Unicode text on Python3. We need to make sure we avoid this behavior change possibly by expanding our use of unicode_literals.
  • String literals in modules that were touched to fix switch to unicode_literals #16 by removing unicode(). e.g. 6382ee3#L3L198. This needs further fixing in presence of the fix for Remove unicode() calls #25.
  • String literals in modules that were touched to add from __future__ import unicode_literals (to fix Remove unicode() calls #25). We need to make sure we prefix them with 'b' or leave them alone according to the original intent and context. I did this in 164c6e0 for two test-related files but I'd like to review all the code.
@ghost ghost assigned ramiro Jul 30, 2012
@ramiro
Copy link
Author

ramiro commented Jul 31, 2012

Advances made in be5d805.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant