You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
String literals in modules that weren't touched to add from __future__ import unicode_literals (to fix Remove unicode() calls #25). In that state these literals are byte-buffers on Python2 and Unicode text on Python3. We need to make sure we avoid this behavior change possibly by expanding our use of unicode_literals.
String literals in modules that were touched to add from __future__ import unicode_literals (to fix Remove unicode() calls #25). We need to make sure we prefix them with 'b' or leave them alone according to the original intent and context. I did this in 164c6e0 for two test-related files but I'd like to review all the code.
The text was updated successfully, but these errors were encountered:
AFAICT at this point we have the following cases:
from __future__ import unicode_literals
(to fix Remove unicode() calls #25). In that state these literals are byte-buffers on Python2 and Unicode text on Python3. We need to make sure we avoid this behavior change possibly by expanding our use ofunicode_literals
.unicode()
. e.g. 6382ee3#L3L198. This needs further fixing in presence of the fix for Remove unicode() calls #25.from __future__ import unicode_literals
(to fix Remove unicode() calls #25). We need to make sure we prefix them with 'b' or leave them alone according to the original intent and context. I did this in 164c6e0 for two test-related files but I'd like to review all the code.The text was updated successfully, but these errors were encountered: