Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make options not required #265

Open
artola opened this issue Feb 11, 2021 · 2 comments
Open

make options not required #265

artola opened this issue Feb 11, 2021 · 2 comments

Comments

@artola
Copy link

artola commented Feb 11, 2021

Passing options in all the methods should be optional, nowadays it is required to pass an empty object.
At present the keys are optional, while probably they have a fallback value in the implementation (e.g., app for keychainService).

Same for master than keystore branch.

// ok
const gettingFirstData = await SInfo.getItem('key1', {
    sharedPreferencesName: 'mySharedPrefs',
    keychainService: 'myKeychain'
});
// ok
const gettingFirstData = await SInfo.getItem('key1', {});
// not allowed
const gettingFirstData = await SInfo.getItem('key1');

See:

export interface RNSensitiveInfoOptions {

@mCodex
Copy link
Owner

mCodex commented Feb 28, 2021

@artola thanks for your suggestion

@stale
Copy link

stale bot commented Mar 30, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants