Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reroute edges of sfnetwork objects #23

Closed
luukvdmeer opened this issue Mar 30, 2020 · 1 comment
Closed

Reroute edges of sfnetwork objects #23

luukvdmeer opened this issue Mar 30, 2020 · 1 comment
Assignees
Labels
duplicate 👯 This issue or pull request already exists feature 🎁 Request a new feature

Comments

@luukvdmeer
Copy link
Owner

Is your feature request related to a problem? Please describe.
In tidygraph, the reroute() verb enables to change the terminal nodes of edges. For example, you can reverse edges with reroute(to = from, from = to). When having spatially explicit edges in an sfnetwork object, rerouting should not just mean changing the from and to columns, but also the geometry column. In the case of reversion, this would mean applying st_reverse() to the geometries.

Describe the solution you'd like
An sfnetwork method for tidygraphs reroute() function, that takes into account the above (only when edges are spatially explicit).

@luukvdmeer luukvdmeer added the feature 🎁 Request a new feature label Mar 30, 2020
@luukvdmeer luukvdmeer added this to the Milestone 2 milestone Mar 30, 2020
@luukvdmeer luukvdmeer self-assigned this Mar 30, 2020
@luukvdmeer luukvdmeer added the duplicate 👯 This issue or pull request already exists label Jun 16, 2020
@luukvdmeer
Copy link
Owner Author

Marked as duplicate of #29

@luukvdmeer luukvdmeer removed this from the Milestone 2 milestone Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate 👯 This issue or pull request already exists feature 🎁 Request a new feature
Projects
None yet
Development

No branches or pull requests

1 participant