Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST][Robot] Refactor Robot test case to improve test step clarity and maintainability #10279

Open
1 task
c3y1huang opened this issue Jan 22, 2025 · 4 comments
Assignees
Labels
highlight Important feature/issue to highlight kind/refactoring Request for refactoring (code) kind/test Request for adding test priority/0 Must be implement or fixed in this release (managed by PO)
Milestone

Comments

@c3y1huang
Copy link
Contributor

What's the test to develop? Please describe

Currently, some keywords contain embedded validation and extra operations, which can lead to complex and hard-to-maintain test cases. To improve clarity and maintainability, we should avoid combining multiple operations within a single keyword.

We need to review all Robot keywords and test cases to ensure that validations and operations are visible at the test case level and that each test step performs only a single operation.

A refactored example: longhorn/longhorn-tests@407bb20

Describe the tasks for the test

  • Refactor test cases, keywords, and libraries to separate multiple operations into distinct steps.

Additional context

https://suse.slack.com/archives/C02HBK5AVC5/p1733103014124679

@c3y1huang c3y1huang added kind/refactoring Request for refactoring (code) kind/test Request for adding test labels Jan 22, 2025
@c3y1huang
Copy link
Contributor Author

cc @derekbit @khushboo-rancher

@github-project-automation github-project-automation bot moved this to New Issues in QA Sprint Jan 22, 2025
@derekbit derekbit added highlight Important feature/issue to highlight priority/0 Must be implement or fixed in this release (managed by PO) labels Jan 22, 2025
@derekbit derekbit added this to the v1.9.0 milestone Jan 22, 2025
@derekbit
Copy link
Member

Thanks to @c3y1huang for pointing out the issue.

Hello @yangchiu,
@c3y1huang and I think the refactoring is a high priority, as the code may become increasingly difficult to maintain and refactor over time. Let's address it first. Thank you.

cc @longhorn/qa @khushboo-rancher @innobead

@yangchiu
Copy link
Member

@derekbit @c3y1huang Feel free to list where you think should be refined to make this ticket more clear. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
highlight Important feature/issue to highlight kind/refactoring Request for refactoring (code) kind/test Request for adding test priority/0 Must be implement or fixed in this release (managed by PO)
Projects
Status: New Issues
Development

No branches or pull requests

3 participants