Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid extfs extents header signature raises IOError #624

Closed
dfjxs opened this issue Jan 7, 2022 · 3 comments
Closed

Invalid extfs extents header signature raises IOError #624

dfjxs opened this issue Jan 7, 2022 · 3 comments
Assignees
@dfjxs

Comments

@dfjxs
Copy link

dfjxs commented Jan 7, 2022

An invalid extfs extents header signature causes a crash. We should instead handle the exception and continue.
@dfjxs dfjxs self-assigned this Jan 7, 2022
@dfjxs dfjxs mentioned this issue Jan 7, 2022
Closed
@joachimmetz joachimmetz changed the title Invalid extfs extents header signature causes crash Invalid extfs extents header signature causes exception Jan 7, 2022
@joachimmetz joachimmetz changed the title Invalid extfs extents header signature causes exception Invalid extfs extents header signature raises IOError Jan 7, 2022
@joachimmetz
Copy link
Member

Regarding #625 I'm not in favor of this solution inside dfVFS, this will silently swallow a file system error, which IMHO is not good practice. It is best to do this in the calling code e.g. https://github.com/open-source-dfir/dfvfs-snippets/blob/main/scripts/recursive_hasher.py#L117

@dfjxs
Copy link
Author

dfjxs commented Jan 7, 2022

You're right, I wasn't catching the exception correctly. Closing the issue.

@dfjxs dfjxs closed this as completed Jan 7, 2022
@joachimmetz
Copy link
Member

libyal/libfsext#7 to address underlying issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dfjxs dfjxs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Catch OS error when parsing EXT
2 participants
@joachimmetz @dfjxs