From f928141d96138a4a3a258123a0a0e4c0426ea0a7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lo=C3=AFc=20Noss?= <74484200+lnoss@users.noreply.github.com> Date: Wed, 20 Dec 2023 14:43:21 +0100 Subject: [PATCH] 0.0.3 => 0.0.4 --- .github/workflows/submit.yml | 2 +- CHANGELOG.md | 16 ++++++++++++++-- package.json | 2 +- 3 files changed, 16 insertions(+), 4 deletions(-) diff --git a/.github/workflows/submit.yml b/.github/workflows/submit.yml index 42dda74..2c1bfe3 100644 --- a/.github/workflows/submit.yml +++ b/.github/workflows/submit.yml @@ -32,7 +32,7 @@ jobs: - name: Build Firefox extension run: | pnpm plasmo build --target=firefox-mv2 --zip - mv build/firefox-mv3-prod.zip firefox-addon-${{ steps.package-version.outputs.current-version }}.zip + mv build/firefox-mv2-prod.zip firefox-addon-${{ steps.package-version.outputs.current-version }}.zip - name: Build Chrome(-ium) extension run: | pnpm plasmo build --target=chrome-mv3 --zip diff --git a/CHANGELOG.md b/CHANGELOG.md index e4d7c77..d92498c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,15 @@ +# Notes + +This version is reverting the migration to MV2 for the Firefox extension. 0.0.3 was working fine on Firefox if you manually approve the permissions. Currently, the workflow doesn't auto request approval or denial of the permissions on installation. Some modifications could be done to browsers workflows to request the permissions on installation, but it seems to not be a priority for now. We will see on june. + +> As of June 2023, Safari, Firefox, and some Chromium-based browsers don't prompt the user during installation. +> https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/host_permissions#requested_permissions_and_user_prompts + +The statement seems false, at least Edge is prompting the user for permissions on installation. I don't know if it's a bug or a feature. 😒 + +# Documentation + +- https://bugzilla.mozilla.org/show_bug.cgi?id=1839129 + # What changed? -- Migrate to Manifest v3 for the Firefox extension -- Support lazy cleaning of lazy loaded results when scrolling \ No newline at end of file +- Reverting migration to MV3 for the Firefox extension until june 2024 at least (see [#5](https://github.com/lnoss/no-google-search-translation/issues/5)) \ No newline at end of file diff --git a/package.json b/package.json index b7d5969..18b0191 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "no-google-search-translation", "displayName": "No Google Search Translation", - "version": "0.0.3", + "version": "0.0.4", "description": "Disable Google Search results auto translation feature. Auto redirect away from Google Translate proxy to the original URL page.", "scripts": { "dev:firefox": "plasmo dev --target=firefox-mv2",