Skip to content
This repository has been archived by the owner on Jan 7, 2024. It is now read-only.

[BUG] Fleet documentation for the unifi image is incorrect #230

Closed
1 task done
marcaurele opened this issue Oct 28, 2023 · 3 comments
Closed
1 task done

[BUG] Fleet documentation for the unifi image is incorrect #230

marcaurele opened this issue Oct 28, 2023 · 3 comments

Comments

@marcaurele
Copy link

marcaurele commented Oct 28, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

The documentation on https://fleet.linuxserver.io/image?name=linuxserver/unifi-controller on the container info tab describes the environment variable MEM_LIMIT with a value containing a suffix M which is incorrect. It must be an integer value describing the value in MB, as correctly described on https://docs.linuxserver.io/images/docker-unifi-controller/#from-2024-01-01-this-image-will-be-deprecated-and-it-will-no-longer-be-updated-please-migrate-to-our-unifi-network-application-image-instead, or on the README of the repository (https://github.com/linuxserver/docker-unifi-controller).

I haven't seen where the documentation of the fleet page is maintained, so I have o idea where I could have push a PR to change the documentation.

Expected Behavior

Be correctly documented without the unit character:

    environment:
      - PUID=1000 # for UserID
      - PGID=1000 # for GroupID
      - MEM_LIMIT=1024 # Optionally change the Java memory limit (-Xmx) (default is 1024M).

Steps To Reproduce

Set the value as described in the doc for the environment variable: MEM_LIMIT=1024M.

Environment

- OS:
- How docker service was installed:

CPU architecture

x86-64

Docker creation

N/A

Container logs

Invalid maximum heap size: -Xmx1024MM
@github-actions
Copy link

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

@LinuxServer-CI
Copy link
Collaborator

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@marcaurele marcaurele changed the title [BUG] Fleet documentation for the unifi image is incorect [BUG] Fleet documentation for the unifi image is incorrect Dec 1, 2023
@drizuid
Copy link
Contributor

drizuid commented Dec 28, 2023

thank you for opening this. unifi-controller will be deprecated in 3 days, so we won't fix this but still appreciate you pointing it out!

@drizuid drizuid closed this as completed Dec 28, 2023
@LinuxServer-CI LinuxServer-CI moved this from Issues to Done in Issue & PR Tracker Dec 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants