Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Show previews in the theme choosers #61

Open
linewelder-old opened this issue Oct 26, 2023 · 1 comment
Open

Feature request: Show previews in the theme choosers #61

linewelder-old opened this issue Oct 26, 2023 · 1 comment

Comments

@linewelder-old
Copy link

linewelder-old commented Oct 26, 2023

Hello,

My suggestion is to show previews in the theme choosers like in the Themes section in settings. It's a small feature, but a very neat one in my opinion.

I tried adding this myself, but my solution depended on ChooserButtonWidgets.py from cinnamon-settings. I don't like this, but I see only two other ways to implement that:

  1. Merge lightdm-settings into cinnamon-settings and leave the dependency there.

  2. Copy the PictureChooserButton class to lightdm-settings (or at least the relevant parts).

I'm ready to work on this myself, but I need advice on addressing that problem.

@clefebvre
Copy link
Member

I wouldn't invest time into this if I were you. Although it's a nice feature it's not really needed.

This is an Xapp, it can't be tied to Cinnamon Settings. You could duplicate the Cinnamon buttons, but there's a lot of work in there to make this work.. I don't know, with GTK5 talking about removing theme supports and all, I'm not sure it's the best time to spend resources on something like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants