Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more TlsProvider implementations #6054

Open
ikhoon opened this issue Jan 2, 2025 · 2 comments
Open

Add more TlsProvider implementations #6054

ikhoon opened this issue Jan 2, 2025 · 2 comments

Comments

@ikhoon
Copy link
Contributor

ikhoon commented Jan 2, 2025

It would be useful to automatically/dynamically update TlsKeyPair when the value of a storage changes such as:

  • Environment variables
  • File system
  • Configuration files on the Central Dogma
  • DBMS, NoSQL
  • ...
@yzfeng2020
Copy link
Contributor

I am also interested in this feature, specifically the File system, do you have a rough idea how to implement that? my idea is to poll/watch the file content from time to time and check if it has changed, wondering if there's a better way.

Another question is when the new TlsKeyPair will take effect? my read of the code is that when a new connection pool is created, the ssl context can be created with the tls key pair. so it's the new pool of connections instead of new connection alone?

thanks!

@ikhoon
Copy link
Contributor Author

ikhoon commented Jan 10, 2025

my idea is to poll/watch the file content from time to time and check if it has changed, wondering if there's a better way.

My idea was also the same.

Another question is when the new TlsKeyPair will take effect?

The new TlsKeyPair will be used when a new connection is created. It is not working at a connection pool level. A HttpChannelPool could use SslContext made from the new TlsKeyPair.

bootstrap = bootstraps.getOrCreate(remoteAddress, desiredProtocol, serializationFormat);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants