Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some typo #5

Open
jszhujun2010 opened this issue Dec 30, 2019 · 0 comments
Open

some typo #5

jszhujun2010 opened this issue Dec 30, 2019 · 0 comments

Comments

@jszhujun2010
Copy link

jszhujun2010 commented Dec 30, 2019

learned a lot from this, some typo found either.
line 177, shape should be [batch, seq_len, target_vocab]

# Make the prediction out of the decoder output.<br/>
logits = tf.layers.dense(dec_out, target_vocab)  # [batch, target_vocab]

line 433, should be num_dec_layers

for i in range(self.num_enc_layers):
    out = self.decoder_layer(out, enc_out, input_mask, target_mask, f'dec_{i}')
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant