Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the "Enable/Disable" button by an "Analytics" one #1016

Open
Marchand-Nicolas opened this issue Dec 27, 2024 · 20 comments
Open

Replace the "Enable/Disable" button by an "Analytics" one #1016

Marchand-Nicolas opened this issue Dec 27, 2024 · 20 comments
Labels
Good first issue Good for newcomers OD Hack Issue reserved for the OD Hack open for contribution An issue that is available for an Only Dust contribution

Comments

@Marchand-Nicolas
Copy link
Collaborator

Description 📹

Replace the "Enable/Disable" button in app/admin/quests/dashboard/[questId]/page.tsx with an "Analytics" button. The new button should open /analytics/{quest_id} in a new tab when clicked.

Proposed Actions 🛠️

Here’s a checklist of actions to follow for resolving this issue:

  1. Fork and Create Branch:
    Fork the repository and create a new branch using the issue number:

    git checkout -b fix-[issue-number]
  2. Implement Changes:

    • Modify the AdminQuestDetails component to replace the existing "Enable/Disable" button with an "Analytics" button.
    • Update the rewardButtonTitle prop to display "Analytics".
    • Update the onRewardButtonClick prop to handle the new button behavior by opening /analytics/{quest_id} in a new tab.

    Updated code snippet:

    <AdminQuestDetails
      quest={questData}
      // eslint-disable-next-line @typescript-eslint/no-empty-function
      setShowDomainPopup={() => {}}
      hasRootDomain={false}
      rewardButtonTitle="Analytics"
      onRewardButtonClick={() => {
        const analyticsUrl = `/analytics/${questData.id}`;
        window.open(analyticsUrl, "_blank");
      }}
      overrideDisabledState={false}
      isEdit={true}
    />
    • Ensure that the questData.id is properly passed to construct the analytics URL.
  3. Run Tests and Commit Changes:
    Make sure your changes don't break existing functionality and commit with a clear message:

    git commit -m "Fix: Replace Enable/Disable button with Analytics button"

Required 📋

To keep our workflow smooth, please make sure you follow these guidelines:

  • Assignment: Don't create a pull request if you weren’t assigned to this issue.
  • Timeframe: Complete the task within 3 business days.
  • Closing the Issue: In your PR description, close the issue by writing Close #[issue_id].
  • Review Process:
    • Once you've submitted your PR, change the label to "ready for review".
    • If changes are requested, address them and then update the label back to "ready for review" once done.
  • Testing: Test your PR locally before pushing, and verify that tests and build are working after pushing.

Thank you for your contribution 🙏

⚠️ WARNING: Failure to follow the requirements above may result in being added to the OnlyDust blacklist, affecting your ability to receive future rewards.

@Marchand-Nicolas Marchand-Nicolas added open for contribution An issue that is available for an Only Dust contribution Good first issue Good for newcomers OD Hack Issue reserved for the OD Hack labels Dec 27, 2024
@Benjtalkshow
Copy link
Contributor

Can I handle this?

@Michaelkingsdev
Copy link

@Marchand-Nicolas
Can i be assigned to this task?

@No-bodyq
Copy link
Contributor

I'd be happy to do this.

@petersdt
Copy link
Contributor

@Marchand-Nicolas I would like to handle this issue. kindly assign me

@NowGoody
Copy link

@Marchand-Nicolas kindly assign me this issue i would like to make it my first contribution the starkquest echo system

@ryzen-xp
Copy link

Can I attempt this issue?

@SudiptaPaul-31
Copy link
Contributor

Would love to tackle this issue

Approach:
First will locate the Enable/Disable button on the codebase and then replace it with an Analytics button and make sure as soon as user clicks on the new button it should open take user to the new route

ETA - 1Day

@Supa-mega
Copy link

Can I tackle this one?

1 similar comment
@VyuduInc
Copy link

Can I tackle this one?

@mimisavage
Copy link

Can I work on this, please

@elmuby
Copy link

elmuby commented Dec 31, 2024

Hi @Marchand-Nicolas i would like to work on this issue as my first issue..
I'm confident I can handle it.
I would love to contribute on this project

@michojekunle
Copy link
Contributor

Hi @Marchand-Nicolas ,

I’d like to work on this issue by:

  • Replacing the "Enable/Disable" button with an "Analytics" button in the specified component.
  • Updating the rewardButtonTitle and onRewardButtonClick props to implement the new functionality, ensuring the button opens /analytics/{quest_id} in a new tab.
  • Testing the changes to confirm proper functionality and compatibility with existing features.

With experience in React and TypeScript, I can ensure a clean and efficient implementation.

ETA 24 HOURS

Looking forward to your approval to proceed!

@chiscookeke11
Copy link

Could I grab this task?

@aidenwong812
Copy link

Let me try this one!

@aurlic
Copy link

aurlic commented Jan 6, 2025

Could I take over this issue?

@Thibrac
Copy link

Thibrac commented Jan 7, 2025

Is this issue still available?

@emarc99
Copy link
Contributor

emarc99 commented Jan 7, 2025

Mind if I take this issue?

@Viktohblake
Copy link

Hello, I’ve reviewed the proposed actions and can implement it seamlessly.

I will make sure to:

  • Replace the "Enable/Disable" button with an "Analytics" button by updating the rewardButtonTitle prop in AdminQuestDetails component.
  • Update the onRewardButtonClick prop, to correctly open /analytics/${questData.id} in a new tab, ensuring questData.id is passed.
  • Test the implementation to make sure that the button behaves as expected.

I look forward to contributing and will prioritise delivering a clean solution.

@Amarjeet325
Copy link

May I pick this up?

@thedevtask
Copy link

I’d like to resolve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Good for newcomers OD Hack Issue reserved for the OD Hack open for contribution An issue that is available for an Only Dust contribution
Projects
None yet
Development

No branches or pull requests