Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port tests #62

Open
gebner opened this issue Nov 30, 2021 · 3 comments
Open

Port tests #62

gebner opened this issue Nov 30, 2021 · 3 comments

Comments

@gebner
Copy link
Member

gebner commented Nov 30, 2021

It would be nice if CI could also synport the test and archive directories of mathlib. Particularly the tests would be super helpful to get test cases for ported tactics without much effort.
@kim-em kim-em mentioned this issue Dec 1, 2021
Closed
@kim-em
Copy link
Contributor

kim-em commented Dec 1, 2021

@gebner, this isn't immediately trivial. mathport gives an error when it meets relative imports, and in mathlib it seems essential to use relative imports in test (and in archive).

@gebner
Copy link
Member Author

gebner commented Dec 1, 2021

There are six relative imports in total, I think it would be completely okay to just ignore them (for now).

@kim-em
Copy link
Contributor

kim-em commented Dec 2, 2021

There are six relative imports in total, I think it would be completely okay to just ignore them (for now).

Okay, trying it out in #64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gebner @kim-em