Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make HapiReader consistent with LaTiS 3 changes #12

Open
lindholc opened this issue Mar 15, 2020 · 2 comments
Open

Make HapiReader consistent with LaTiS 3 changes #12

lindholc opened this issue Mar 15, 2020 · 2 comments

Comments

@lindholc
Copy link
Member

The DatasetReader interface has changed since HapiReader was written.
@lindholc lindholc self-assigned this Mar 15, 2020
@lindholc lindholc mentioned this issue Mar 15, 2020
Closed
@lindholc
Copy link
Member Author

@dlindhol, I'm confused about what DatasetReader does now.

DatasetReader now has an abstract model member that needs to be defined to make a non-abstract implementation like HapiReader. However, HapiReader currently computes the model from the given URI.

Does that mean DatasetReaders need to be given the model rather than compute it themselves? So HapiReader would be constructed with a model? Is HapiReader an abstract class that does most of what's necessary for getting a dataset from a HAPI server but needs to have subclasses (anonymous or not) for specific datasets?

@dlindhol
Copy link
Member

We can remove the model from the DatasetReader. I added that to support the ReaderOperation used only in Hylatis, so far. We can find another way.

@lindholc lindholc removed their assignment Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lindholc @dlindhol