Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove virtual package requirement laminas/laminas-cache-storage-implementation #278

Closed
boesing opened this issue Oct 8, 2023 · 1 comment · Fixed by #289
Closed

Remove virtual package requirement laminas/laminas-cache-storage-implementation #278

boesing opened this issue Oct 8, 2023 · 1 comment · Fixed by #289

Comments

@boesing
Copy link
Member

boesing commented Oct 8, 2023

Feature Request

Q A
New Feature yes
RFC yes
BC Break no

Summary

When working on laminas-cache-storage-adapter-benchmark and laminas-cache-storage-adapter-test, having to fulfill the requirement of laminas/laminas-cache-storage-implementation by requiring one of the adapters introduces a bunch of pain.

Whenever there are new major versions to laminas-cache, this becomes a huge pain since first, benchmark and test packages have to support the new major before the adapters itself can get updated and then the actual implementations can bump to the new major (including tests, etc.).

We initially added laminas/laminas-cache-storage-implementation to ensure that there are no projects out there to "upgrade" without having any implementation in-place. With v4, we could now remove this requirement.
Any setup guide is already pointing the users to require the specific cache backend + laminas-cache itself.

I already proposed a change to composer itself to be able to kinda "ignore" virtual packages for non-project packages in composer/composer#11671 but that seems to be against what composer expects how dependency inversion works.
I still think it would be helpful if composer is actually ignoring virtual package requirements in "library" packages but I don't think that this will happen any time soon and thus, I propose to remove laminas/laminas-cache-storage-implementation in v4.0.0.

Any thoughts about this?

@boesing
Copy link
Member Author

boesing commented Feb 28, 2024

Closed with #289

@boesing boesing closed this as completed Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant