Pluralization discrepancy in UnsafeGuessKindToResource still exists #1082

Limorerez · 2022-04-07T16:34:58Z

Expected:

gateway-> gateways
Got:
gateway-> gatewaies

Is there any way to affect this mistaken guessing?

AlexanderYastrebov · 2022-05-19T21:31:28Z

Is there any way to affect this mistaken guessing?

A workaround is to pass empty list of objects

client-go/kubernetes/fake/clientset_generated.go

Lines 124 to 130 in cab7ba1

    
           func NewSimpleClientset(objects ...runtime.Object) *Clientset { 
        
           	o := testing.NewObjectTracker(scheme, codecs.UniversalDecoder()) 
        
           	for _, obj := range objects { 
        
           		if err := o.Add(obj); err != nil { 
        
           			panic(err) 
        
           		} 
        
           	}

and manually use Create() on the tracker instead of Add() as suggested here

client-go/testing/fixture.go

Lines 326 to 330 in cab7ba1

    
           // NOTE: UnsafeGuessKindToResource is a heuristic and default match. The 
        
           // actual registration in apiserver can specify arbitrary route for a 
        
           // gvk. If a test uses such objects, it cannot preset the tracker with 
        
           // objects via Add(). Instead, it should trigger the Create() function 
        
           // of the tracker, where an arbitrary gvr can be specified.

AlexanderYastrebov · 2022-05-19T21:50:29Z

Also https://github.com/kubernetes/code-generator uses https://pkg.go.dev/k8s.io/gengo/namer#NewAllLowercasePluralNamer

pmalek · 2022-08-08T18:08:52Z

I've also stumbled across this when using

		dynClient := dyn_fake.NewSimpleDynamicClientWithCustomListKinds(scheme.Scheme,
			map[schema.GroupVersionResource]string{
				{
					Group:    "gateway.networking.k8s.io",
					Version:  "v1beta1",
					Resource: "gateways",
				}: "GatewayList",
			},
			...
		)

and then listing a gateway (via unstructured client) yields

panic: coding error: you must register resource to list kind for every resource you're going to LIST when creating the client.  See NewSimpleDynamicClientWithCustomListKinds or register the list into the scheme: gateway.networking.k8s.io/v1beta1, Resource=gateways out of map[/, Resource=:List /v1, Resource=apigroups:APIGroupList /v1, Resource=apiresources:APIResourceList /v1, Resource=componentstatuses:ComponentStatusList /v1, Resource=configmaps:ConfigMapList /v1, Resource=endpoints:EndpointsList /v1, Resource=events:EventList /v1, Resource=limitranges:LimitRangeList /v1, Resource=namespaces:NamespaceList /v1, Resource=nodes:NodeList /v1, Resource=persistentvolumeclaims:PersistentVolumeClaimList /v1, Resource=persistentvolumes:PersistentVolumeList /v1, Resource=pods:PodList /v1, Resource=podtemplates:PodTemplateList /v1, Resource=replicationcontrollers:ReplicationControllerList /v1, Resource=resourcequotas:ResourceQuotaList /v1, Resource=secrets:SecretList /v1, Resource=serviceaccounts:ServiceAccountList /v1, Resource=services:ServiceList admissionregistration.k8s.io/v1, Resource=mutatingwebhookconfigurations:MutatingWebhookConfigurationList admissionregistration.k8s.io/v1, Resource=validatingwebhookconfigurations:ValidatingWebhookConfigurationList admissionregistration.k8s.io/v1beta1, Resource=mutatingwebhookconfigurations:MutatingWebhookConfigurationList admissionregistration.k8s.io/v1beta1, Resource=validatingwebhookconfigurations:ValidatingWebhookConfigurationList apps/v1, Resource=controllerrevisions:ControllerRevisionList apps/v1, Resource=daemonsets:DaemonSetList apps/v1, Resource=deployments:DeploymentList apps/v1, Resource=replicasets:ReplicaSetList apps/v1, Resource=statefulsets:StatefulSetList apps/v1beta1, Resource=controllerrevisions:ControllerRevisionList apps/v1beta1, Resource=deployments:DeploymentList apps/v1beta1, Resource=statefulsets:StatefulSetList apps/v1beta2, Resource=controllerrevisions:ControllerRevisionList apps/v1beta2, Resource=daemonsets:DaemonSetList apps/v1beta2, Resource=deployments:DeploymentList apps/v1beta2, Resource=replicasets:ReplicaSetList apps/v1beta2, Resource=statefulsets:StatefulSetList autoscaling/v1, Resource=horizontalpodautoscalers:HorizontalPodAutoscalerList autoscaling/v2, Resource=horizontalpodautoscalers:HorizontalPodAutoscalerList autoscaling/v2beta1, Resource=horizontalpodautoscalers:HorizontalPodAutoscalerList autoscaling/v2beta2, Resource=horizontalpodautoscalers:HorizontalPodAutoscalerList batch/v1, Resource=cronjobs:CronJobList batch/v1, Resource=jobs:JobList batch/v1beta1, Resource=cronjobs:CronJobList certificates.k8s.io/v1, Resource=certificatesigningrequests:CertificateSigningRequestList certificates.k8s.io/v1beta1, Resource=certificatesigningrequests:CertificateSigningRequestList coordination.k8s.io/v1, Resource=leases:LeaseList coordination.k8s.io/v1beta1, Resource=leases:LeaseList discovery.k8s.io/v1, Resource=endpointslices:EndpointSliceList discovery.k8s.io/v1beta1, Resource=endpointslices:EndpointSliceList events.k8s.io/v1, Resource=events:EventList events.k8s.io/v1beta1, Resource=events:EventList extensions/v1beta1, Resource=daemonsets:DaemonSetList extensions/v1beta1, Resource=deployments:DeploymentList extensions/v1beta1, Resource=ingresses:IngressList extensions/v1beta1, Resource=networkpolicies:NetworkPolicyList extensions/v1beta1, Resource=podsecuritypolicies:PodSecurityPolicyList extensions/v1beta1, Resource=replicasets:ReplicaSetList flowcontrol.apiserver.k8s.io/v1alpha1, Resource=flowschemas:FlowSchemaList flowcontrol.apiserver.k8s.io/v1alpha1, Resource=prioritylevelconfigurations:PriorityLevelConfigurationList flowcontrol.apiserver.k8s.io/v1beta1, Resource=flowschemas:FlowSchemaList flowcontrol.apiserver.k8s.io/v1beta1, Resource=prioritylevelconfigurations:PriorityLevelConfigurationList flowcontrol.apiserver.k8s.io/v1beta2, Resource=flowschemas:FlowSchemaList flowcontrol.apiserver.k8s.io/v1beta2, Resource=prioritylevelconfigurations:PriorityLevelConfigurationList gateway.networking.k8s.io/v1beta1, Resource=gatewaies:GatewayList gateway.networking.k8s.io/v1beta1, Resource=gatewayclasses:GatewayClassList gateway.networking.k8s.io/v1beta1, Resource=httproutes:HTTPRouteList internal.apiserver.k8s.io/v1alpha1, Resource=storageversions:StorageVersionList networking.k8s.io/v1, Resource=ingressclasses:IngressClassList networking.k8s.io/v1, Resource=ingresses:IngressList networking.k8s.io/v1, Resource=networkpolicies:NetworkPolicyList networking.k8s.io/v1beta1, Resource=ingressclasses:IngressClassList networking.k8s.io/v1beta1, Resource=ingresses:IngressList node.k8s.io/v1, Resource=runtimeclasses:RuntimeClassList node.k8s.io/v1alpha1, Resource=runtimeclasses:RuntimeClassList node.k8s.io/v1beta1, Resource=runtimeclasses:RuntimeClassList policy/v1, Resource=poddisruptionbudgets:PodDisruptionBudgetList policy/v1beta1, Resource=poddisruptionbudgets:PodDisruptionBudgetList policy/v1beta1, Resource=podsecuritypolicies:PodSecurityPolicyList rbac.authorization.k8s.io/v1, Resource=clusterrolebindings:ClusterRoleBindingList rbac.authorization.k8s.io/v1, Resource=clusterroles:ClusterRoleList rbac.authorization.k8s.io/v1, Resource=rolebindings:RoleBindingList rbac.authorization.k8s.io/v1, Resource=roles:RoleList rbac.authorization.k8s.io/v1alpha1, Resource=clusterrolebindings:ClusterRoleBindingList rbac.authorization.k8s.io/v1alpha1, Resource=clusterroles:ClusterRoleList rbac.authorization.k8s.io/v1alpha1, Resource=rolebindings:RoleBindingList rbac.authorization.k8s.io/v1alpha1, Resource=roles:RoleList rbac.authorization.k8s.io/v1beta1, Resource=clusterrolebindings:ClusterRoleBindingList rbac.authorization.k8s.io/v1beta1, Resource=clusterroles:ClusterRoleList rbac.authorization.k8s.io/v1beta1, Resource=rolebindings:RoleBindingList rbac.authorization.k8s.io/v1beta1, Resource=roles:RoleList scheduling.k8s.io/v1, Resource=priorityclasses:PriorityClassList scheduling.k8s.io/v1alpha1, Resource=priorityclasses:PriorityClassList scheduling.k8s.io/v1beta1, Resource=priorityclasses:PriorityClassList storage.k8s.io/v1, Resource=csidrivers:CSIDriverList storage.k8s.io/v1, Resource=csinodes:CSINodeList storage.k8s.io/v1, Resource=csistoragecapacities:CSIStorageCapacityList storage.k8s.io/v1, Resource=storageclasses:StorageClassList storage.k8s.io/v1, Resource=volumeattachments:VolumeAttachmentList storage.k8s.io/v1alpha1, Resource=csistoragecapacities:CSIStorageCapacityList storage.k8s.io/v1alpha1, Resource=volumeattachments:VolumeAttachmentList storage.k8s.io/v1beta1, Resource=csidrivers:CSIDriverList storage.k8s.io/v1beta1, Resource=csinodes:CSINodeList storage.k8s.io/v1beta1, Resource=csistoragecapacities:CSIStorageCapacityList storage.k8s.io/v1beta1, Resource=storageclasses:StorageClassList storage.k8s.io/v1beta1, Resource=volumeattachments:VolumeAttachmentList]

Resource=gatewaies:GatewayList gateway.networking.k8s.io/v1beta1

from k8s.io/[email protected]/dynamic/fake/simple.go:353.

Any work arounds for this?

pmalek · 2022-08-09T08:25:50Z

I tried adding a test case in https://github.com/kubernetes/gengo/blob/940203f2dae74b24bb30948aa5a9619ba259d4a5/namer/plural_namer_test.go to verify that this is indeed broken for Gateway/gateway but it doesn't look like that's the case. I've even checked several versions back to verify which version of gengo is being used by https://github.com/kubernetes/code-generator and match that with my cluster's version and that didn't yield a failure.

Ok, got it: kubernetes/kubernetes#110053

k8s-triage-robot · 2022-11-07T09:09:29Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

pmalek · 2022-11-07T11:10:07Z

/remove-lifecycle stale

k8s-triage-robot · 2023-02-05T11:14:21Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

pmalek · 2023-02-12T18:16:48Z

Still an issue (I'm mostly bumping this because of the problem with Gateway APIs).

/remove-lifecycle stale

k8s-triage-robot · 2023-05-13T18:58:35Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue as fresh with /remove-lifecycle stale
Close this issue with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

pmalek · 2023-06-11T08:46:11Z

There seem to be a potential way forward to fix this. I've posted kubernetes/kubernetes#110053 (comment) to ensure it's "the right way" and if that's the case I can propose something for everyone to review.

/remove-lifecycle stale

k8s-triage-robot · 2024-01-22T07:30:04Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue as fresh with /remove-lifecycle stale
Close this issue with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

mrueg · 2024-01-22T07:48:45Z

/remove-lifecycle stale

k8s-triage-robot · 2024-04-21T08:04:57Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue as fresh with /remove-lifecycle stale
Close this issue with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

pmalek · 2024-05-05T15:12:59Z

/remove-lifecycle stale

k8s-triage-robot · 2024-08-03T15:54:53Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue as fresh with /remove-lifecycle stale
Close this issue with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

mjnovice · 2024-08-09T22:52:51Z

any updates ?

k8s-triage-robot · 2024-09-08T23:22:28Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue as fresh with /remove-lifecycle rotten
Close this issue with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2024-10-09T00:04:24Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Reopen this issue with /reopen
Mark this issue as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot · 2024-10-09T00:04:29Z

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Reopen this issue with /reopen

Mark this issue as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

pmalek · 2024-10-09T07:03:42Z

/reopen
/remove-lifecycle rotten

k8s-ci-robot · 2024-10-09T07:03:47Z

@pmalek: Reopened this issue.

In response to this:

/reopen
/remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-triage-robot · 2025-01-07T07:41:02Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue as fresh with /remove-lifecycle stale
Close this issue with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

michaelbeaumont mentioned this issue May 14, 2022

apimachinery: fix UnsafeGuessKindToResource for some classes of words kubernetes/kubernetes#110053

Closed

pmalek mentioned this issue Aug 8, 2022

feat: add hostname, uptime and gateway count providers Kong/kubernetes-telemetry#40

Merged

wreed4 mentioned this issue Aug 18, 2022

Some resources cannot use success/failure conditions at all due to bug in UnsafeGuessKindToResource argoproj/argo-workflows#9393

Closed

3 tasks

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 7, 2022

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 7, 2022

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 5, 2023

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 12, 2023

mrueg mentioned this issue Apr 26, 2023

customresource GitRepo cannot be scraped kubernetes/kube-state-metrics#2051

Closed

mrueg mentioned this issue May 10, 2023

Plural field in constraints CRD is always singular open-policy-agent/gatekeeper#2751

Closed

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 13, 2023

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 11, 2023

pmalek mentioned this issue Dec 9, 2023

Cannot use client-go's fake client with Gateway API objects kubernetes/kubernetes#116253

Open

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 22, 2024

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 22, 2024

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 21, 2024

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 5, 2024

pmalek mentioned this issue Jun 20, 2024

chore: check if AIGateway CRD exists in the cluster before creating a count provider Kong/gateway-operator#360

Merged

jm-franc mentioned this issue Jul 20, 2024

Fix Kind pluralization. kubernetes/perf-tests#2773

Merged

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 3, 2024

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 8, 2024

k8s-ci-robot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 9, 2024

k8s-ci-robot reopened this Oct 9, 2024

k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Oct 9, 2024

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 7, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pluralization discrepancy in UnsafeGuessKindToResource still exists #1082

Pluralization discrepancy in UnsafeGuessKindToResource still exists #1082

Limorerez commented Apr 7, 2022 •

edited

Loading

AlexanderYastrebov commented May 19, 2022

AlexanderYastrebov commented May 19, 2022

pmalek commented Aug 8, 2022 •

edited

Loading

pmalek commented Aug 9, 2022

k8s-triage-robot commented Nov 7, 2022

pmalek commented Nov 7, 2022

k8s-triage-robot commented Feb 5, 2023

pmalek commented Feb 12, 2023

k8s-triage-robot commented May 13, 2023

pmalek commented Jun 11, 2023

k8s-triage-robot commented Jan 22, 2024

mrueg commented Jan 22, 2024

k8s-triage-robot commented Apr 21, 2024

pmalek commented May 5, 2024

k8s-triage-robot commented Aug 3, 2024

mjnovice commented Aug 9, 2024

k8s-triage-robot commented Sep 8, 2024

k8s-triage-robot commented Oct 9, 2024

k8s-ci-robot commented Oct 9, 2024

pmalek commented Oct 9, 2024

k8s-ci-robot commented Oct 9, 2024

k8s-triage-robot commented Jan 7, 2025

Pluralization discrepancy in UnsafeGuessKindToResource still exists #1082

Pluralization discrepancy in UnsafeGuessKindToResource still exists #1082

Comments

Limorerez commented Apr 7, 2022 • edited Loading

AlexanderYastrebov commented May 19, 2022

AlexanderYastrebov commented May 19, 2022

pmalek commented Aug 8, 2022 • edited Loading

pmalek commented Aug 9, 2022

k8s-triage-robot commented Nov 7, 2022

pmalek commented Nov 7, 2022

k8s-triage-robot commented Feb 5, 2023

pmalek commented Feb 12, 2023

k8s-triage-robot commented May 13, 2023

pmalek commented Jun 11, 2023

k8s-triage-robot commented Jan 22, 2024

mrueg commented Jan 22, 2024

k8s-triage-robot commented Apr 21, 2024

pmalek commented May 5, 2024

k8s-triage-robot commented Aug 3, 2024

mjnovice commented Aug 9, 2024

k8s-triage-robot commented Sep 8, 2024

k8s-triage-robot commented Oct 9, 2024

k8s-ci-robot commented Oct 9, 2024

pmalek commented Oct 9, 2024

k8s-ci-robot commented Oct 9, 2024

k8s-triage-robot commented Jan 7, 2025

Limorerez commented Apr 7, 2022 •

edited

Loading

pmalek commented Aug 8, 2022 •

edited

Loading