Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the Pod TAS label in favor of an indexed field based on Workload #4041

Open
mimowo opened this issue Jan 23, 2025 · 2 comments
Open

Drop the Pod TAS label in favor of an indexed field based on Workload #4041

mimowo opened this issue Jan 23, 2025 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@mimowo
Copy link
Contributor

mimowo commented Jan 23, 2025

What would you like to be added:

We would drop the use of the Pod TAS label which is used for filtering out the pods managed by TAS:

// TASLabel is a label set on the Job's PodTemplate to indicate that the
// PodSet is admitted using TopologyAwareScheduling, and all Pods created
// from the Job's PodTemplate also have the label. For the Pod-based
// integrations the label is added in webhook during the Pod creation.
TASLabel = "kueue.x-k8s.io/tas"

This was requested as a cleanup in the comment: #3271 (comment)

However, if we hit roadblocks, we should revisit the proposal of dropping the label,

Why is this needed:

To avoid using labels which duplicate the information which is already present in the workload.

@mimowo mimowo added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 23, 2025
@mimowo
Copy link
Contributor Author

mimowo commented Jan 23, 2025

cc @PBundyra @tenzen-y

@mimowo
Copy link
Contributor Author

mimowo commented Jan 23, 2025

cc @mbobrovskyi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

1 participant