Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract multikueue integration tests to a dedicated CI job #4040

Open
mimowo opened this issue Jan 23, 2025 · 2 comments
Open

Extract multikueue integration tests to a dedicated CI job #4040

mimowo opened this issue Jan 23, 2025 · 2 comments
Assignees
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@mimowo
Copy link
Contributor

mimowo commented Jan 23, 2025

What would you like to be cleaned:

I would like to extract the integration multikueue tests to a dedicated suite.

Why is this needed:

The multikueue integration tests are quite heavy in nature, because:

  • we run 3 instances of Kueue to simulate execution of 3 clusters (see here)
  • we install opt-in CRDs to test MultiKueue with different frameworks (see here)
  • they run INTEGRATION_NPROC=4 as other "lightweight" integration tests

For the experiments in the context of Kuberay multikueue integrations tests we learned that:

  • increasing resources for the job for integration tests helped a little bit, but didn't fully solve the problem with running Ray (see comment)
  • we know that setting INTEGRATION_NPROC=3 makes the tests usually pass, but it means lower parallelism enforced on the lightweight tests, which is not ideal

Another argument for the separate CI job is that the integration tests take long (around 18 min currently): https://prow.k8s.io/job-history/gs/kubernetes-ci-logs/logs/periodic-kueue-test-integration-main.

The MK integration tests take around 1min 50s of the time, so we could offload the main integration suite and allow for lower parallelism on the MK suite.

@mimowo mimowo added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 23, 2025
@mimowo
Copy link
Contributor Author

mimowo commented Jan 23, 2025

cc @mszadkow @mbobrovskyi
WDYT @tenzen-y ?

@mszadkow
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

No branches or pull requests

2 participants