Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commonize the code for checking if workload is managed by Kueue #4000

Open
mimowo opened this issue Jan 17, 2025 · 1 comment
Open

Commonize the code for checking if workload is managed by Kueue #4000

mimowo opened this issue Jan 17, 2025 · 1 comment
Assignees
@mbobrovskyi
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@mimowo
Copy link
Contributor

mimowo commented Jan 17, 2025

What would you like to be cleaned:

As in the comment we have two instances of the same logic:

  1. in WorkloadShouldBeSuspended - first two checks
  2. and in the new LWS PR we have IsManagedByKueue

Why is this needed:

To avoid duplication of complex logic, and so to reduce a chance of bugs.
@mimowo mimowo added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 17, 2025
@mimowo
Copy link
Contributor Author

mimowo commented Jan 17, 2025

/assign @mbobrovskyi

@mimowo mimowo mentioned this issue Jan 17, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbobrovskyi mbobrovskyi

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mimowo @mbobrovskyi