"Start any time" has no effect when creating new timer rule

[mtandrup]

Hi

Kodi 18.0
TVMosaic 1.0.0 17051
TVMosaic PVR addon 4.7.1
Running TVMosaic on Windows 10.
Running Kodi on multiple machines: Windows 10 and RPi.

When I program a new timer rule, the "Start any time" option is not respected.
I set it to disabled, but when I go in to the "Timer rules" afterwards and check it, it is always enabled, resulting in programs being recorded whenever they are aired, instead of just recording the ones in the specific time period.

If I disable the "Start any time" option afterwards, by editing the timer under "Timer rules", it works from then on.

Best regards
Michael Tandrup
Denmark

[dvblogic]

The reason for this behavior is that TVMosaic and Kodi use two different models for that flag.
In Kodi - it is just a boolean, while TVMosaic uses "starts after" and "starts before" times.
I do not know yet how to map one on another without different clients overwriting each other settings.

[linknetx]

The reason for this behavior is that TVMosaic and Kodi use two different models for that flag.
In Kodi - it is just a boolean, while TVMosaic uses "starts after" and "starts before" times.
I do not know yet how to map one on another without different clients overwriting each other settings.

@dvblogic

What I don't understand is that when editing a Series Timer Rule in Kodi, setting Start Any Time to disabled works perfectly. It is only when creating a new Series Timer Rule that it fails to work. So TVMosaic must be able to apply the bool and create start and end times when editing but not when creating a new rule

[dvblogic]

TVMosaic can report a correct boolean value, but can only set it to true. There is no way to reset it (e.g. set it to false) it, because Kodi has a boolean and TVMosaic has two times - start before and start after. Even if we convert boolean into something like +- 15 minutes around start time, then it will effectively reset any other values set by other clients.

[ksooo]

Unrelated, but knowing you're reading this : your last master commit misses an addon version bump and without tagging that commit new version will never get released, for instance it will never appear in the official binary addon repo.

[dvblogic]

@ksooo I know, but thanks for the reminder.
I just thought that we can squeeze more things into this update and then bump a version.

[ksooo]

👍

[ksooo]

Please don't forget that people grab whatever they can get from master (Milhouse libreelec nightly builds for example- used by many people), build and "release" to the wild . Then, people start to report bugs for addon version x.y.z and you never know whether this is about official x.y.z or the interim "version" without version bump. Thus, I suggest to always include a version bump with every functional change PR.

[linknetx]

TVMosaic can report a correct boolean value, but can only set it to true. There is no way to reset it (e.g. set it to false) it, because Kodi has a boolean and TVMosaic has two times - start before and start after. Even if we convert boolean into something like +- 15 minutes around start time, then it will effectively reset any other values set by other clients.

I understand what you are saying but please consider these two cases;

1. Create a new Timer in Kodi with Start Any Time as false (it doesn't work which we know) Now open TVMosaic and select edit Timer and there are no start before and start after times set.

2. Now edit the same Timer in Kodi and set Start Any Time as false (this now works). Now open TVMosaic and select edit Timer and there are start before and start after times set at 15 minutes either side of the start time.

So in case 2 when editing the Timer, somewhere, either in Kodi or in the DVBLink Addon the bool false is getting converted to start before and start after times. But not, as in case 1, when initially creating the timer.

[dvblogic]

Functionality has been removed in pull request #119 until better solution is found

[linknetx]

@dvblogic

Is there any progress on this?

Presumably this is waiting for a server revision to reinstate the code which worked in version 6.xx, is that the case?

Having this disabled is actually worse than before since now it can't be used at all whereas before it would always work when editing a timer and thus proved very useful.

[linknetx]

@dvblogic

Is there any progress on this?

Presumably this is waiting for a server revision to reinstate the code which worked in version 6.xx, is that the case?

Having this disabled is actually worse than before since now it can't be used at all whereas before it would always work when editing a timer and thus proved very useful.

Does anybody ever read this issue report ????????????

[mtandrup]

Any news regarding this issue?