Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider moving releaseLock to setupExitHandlers cleanup in relayerHelpers.ts #380

Open
coderabbitai bot opened this issue Dec 10, 2024 · 1 comment
Open

Consider moving releaseLock to setupExitHandlers cleanup in relayerHelpers.ts #380

coderabbitai bot opened this issue Dec 10, 2024 · 1 comment
Assignees
@fcanela

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 10, 2024

As per this comment in PR #377, we should consider moving releaseLock from updateStateFile to setupExitHandlers during cleanup. This issue is created as requested by @fcanela.
@fcanela
Copy link
Contributor

fcanela commented Dec 10, 2024

During the refactor we noticed that the releaseLock logic was placed in an incorrect place: it would release the lock unintentionally, allowing multiple executions of the app.

The logic should me moved so the lockfile is only released when the application is about to exit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fcanela fcanela

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fcanela