From f62a9ebb668e0eff63cdda8925e20bd635d2dc45 Mon Sep 17 00:00:00 2001
From: kemuru <102478601+kemuru@users.noreply.github.com>
Date: Mon, 30 Sep 2024 14:40:53 +0200
Subject: [PATCH] fix: style font size smaller, optimize variable calculations

---
 .../PreviewCardButtons/RaiseDisputeButton.tsx | 63 +++++++++++--------
 .../DepositPaymentButton.tsx                  | 40 ++++--------
 2 files changed, 50 insertions(+), 53 deletions(-)

diff --git a/web/src/pages/MyTransactions/TransactionDetails/PreviewCardButtons/RaiseDisputeButton.tsx b/web/src/pages/MyTransactions/TransactionDetails/PreviewCardButtons/RaiseDisputeButton.tsx
index f4b822a..576d8ca 100644
--- a/web/src/pages/MyTransactions/TransactionDetails/PreviewCardButtons/RaiseDisputeButton.tsx
+++ b/web/src/pages/MyTransactions/TransactionDetails/PreviewCardButtons/RaiseDisputeButton.tsx
@@ -1,6 +1,6 @@
 import React, { useMemo, useState } from "react";
 import { Button } from "@kleros/ui-components-library";
-import { useAccount, usePublicClient } from "wagmi";
+import { useAccount, useBalance, usePublicClient } from "wagmi";
 import {
   useWriteEscrowUniversalPayArbitrationFeeByBuyer,
   useWriteEscrowUniversalPayArbitrationFeeBySeller,
@@ -11,6 +11,8 @@ import { isUndefined } from "utils/index";
 import { wrapWithToast } from "utils/wrapWithToast";
 import { useTransactionDetailsContext } from "context/TransactionDetailsContext";
 import { useQueryRefetch } from "hooks/useQueryRefetch";
+import ClosedCircleIcon from "components/StyledIcons/ClosedCircleIcon";
+import { ErrorButtonMessage } from "pages/NewTransaction/NavigationButtons/DepositPaymentButton";
 
 interface IRaiseDisputeButton {
   toggleModal?: () => void;
@@ -25,29 +27,33 @@ const RaiseDisputeButton: React.FC<IRaiseDisputeButton> = ({ toggleModal, button
   const { buyer, id } = useTransactionDetailsContext();
   const isBuyer = useMemo(() => address?.toLowerCase() === buyer?.toLowerCase(), [address, buyer]);
   const refetchQuery = useQueryRefetch();
+  const { data: balanceData } = useBalance({
+    address: address as `0x${string}` | undefined,
+  });
 
-  const { data: payArbitrationFeeByBuyerConfig, isLoading: isPreparingBuyerConfig } =
-    useSimulateEscrowUniversalPayArbitrationFeeByBuyer({
-      query: {
-        enabled: isBuyer,
-      },
-      args: [BigInt(id)],
-      value: arbitrationCost,
-    });
+  const insufficientBalance = parseFloat(arbitrationCost.toString()) > parseFloat(balanceData?.value.toString() || "0");
 
-  const { data: payArbitrationFeeBySellerConfig, isLoading: isPreparingSellerConfig } =
-    useSimulateEscrowUniversalPayArbitrationFeeBySeller({
-      query: {
-        enabled: !isBuyer,
-      },
-      args: [BigInt(id)],
-      value: arbitrationCost,
-    });
+  const { data: payArbitrationFeeByBuyerConfig } = useSimulateEscrowUniversalPayArbitrationFeeByBuyer({
+    query: {
+      enabled: isBuyer,
+    },
+    args: [BigInt(id)],
+    value: arbitrationCost,
+  });
+
+  const { data: payArbitrationFeeBySellerConfig } = useSimulateEscrowUniversalPayArbitrationFeeBySeller({
+    query: {
+      enabled: !isBuyer,
+    },
+    args: [BigInt(id)],
+    value: arbitrationCost,
+  });
 
   const { writeContractAsync: payArbitrationFeeByBuyer } =
     useWriteEscrowUniversalPayArbitrationFeeByBuyer(payArbitrationFeeByBuyerConfig);
-  const { writeContractAsync: payArbitrationFeeBySeller } =
-    useWriteEscrowUniversalPayArbitrationFeeBySeller(payArbitrationFeeBySellerConfig);
+  const { writeContractAsync: payArbitrationFeeBySeller } = useWriteEscrowUniversalPayArbitrationFeeBySeller(
+    payArbitrationFeeBySellerConfig
+  );
 
   const handleRaiseDispute = () => {
     if (isBuyer && !isUndefined(payArbitrationFeeByBuyer)) {
@@ -84,12 +90,19 @@ const RaiseDisputeButton: React.FC<IRaiseDisputeButton> = ({ toggleModal, button
   };
 
   return (
-    <Button
-      isLoading={isSending || isPreparingBuyerConfig || isPreparingSellerConfig}
-      disabled={isSending || isPreparingBuyerConfig || isPreparingSellerConfig}
-      text={buttonText}
-      onClick={handleRaiseDispute}
-    />
+    <div>
+      <Button
+        isLoading={isSending}
+        disabled={isSending || insufficientBalance}
+        text={buttonText}
+        onClick={handleRaiseDispute}
+      />
+      {insufficientBalance && (
+        <ErrorButtonMessage>
+          <ClosedCircleIcon /> Insufficient balance
+        </ErrorButtonMessage>
+      )}
+    </div>
   );
 };
 
diff --git a/web/src/pages/NewTransaction/NavigationButtons/DepositPaymentButton.tsx b/web/src/pages/NewTransaction/NavigationButtons/DepositPaymentButton.tsx
index b506f2c..f281363 100644
--- a/web/src/pages/NewTransaction/NavigationButtons/DepositPaymentButton.tsx
+++ b/web/src/pages/NewTransaction/NavigationButtons/DepositPaymentButton.tsx
@@ -29,13 +29,14 @@ import ClosedCircleIcon from "components/StyledIcons/ClosedCircleIcon";
 
 const StyledButton = styled(Button)``;
 
-const ErrorMessage = styled.div`
+export const ErrorButtonMessage = styled.div`
   display: flex;
   align-items: center;
   gap: 4px;
   justify-content: center;
   margin: 12px;
   color: ${({ theme }) => theme.error};
+  font-size: 14px;
 `;
 
 const DepositPaymentButton: React.FC = () => {
@@ -49,10 +50,8 @@ const DepositPaymentButton: React.FC = () => {
     deadline,
     sendingToken,
     resetContext,
-    setHasSufficientNativeBalance,
   } = useNewTransactionContext();
 
-  const [finalRecipientAddress, setFinalRecipientAddress] = useState(sellerAddress);
   const publicClient = usePublicClient();
   const navigateAndScrollTop = useNavigateAndScrollTop();
   const refetchQuery = useQueryRefetch();
@@ -67,32 +66,14 @@ const DepositPaymentButton: React.FC = () => {
     [isNativeTransaction, sendingQuantity]
   );
 
+  const finalRecipientAddress = ensResult.data || sellerAddress;
+
   const { data: balanceData } = useBalance({
     address: address as `0x${string}` | undefined,
-    token: isNativeTransaction ? undefined : sendingToken?.address as `0x${string}` | undefined,
+    token: isNativeTransaction ? undefined : (sendingToken?.address as `0x${string}` | undefined),
   });
 
-  const [error, setError] = useState<string | null>(null);
-
-  useEffect(() => {
-    setFinalRecipientAddress(ensResult.data || sellerAddress);
-  }, [sellerAddress, ensResult.data]);
-
-  useEffect(() => {
-    const balance = parseFloat(balanceData?.formatted || "0");
-    const quantity = parseFloat(sendingQuantity);
-
-    if (quantity > balance) {
-      setError("Insufficient balance");
-      setHasSufficientNativeBalance(false);
-    } else if (quantity === 0) {
-      setError("Amount cannot be zero");
-      setHasSufficientNativeBalance(false);
-    } else {
-      setError(null);
-      setHasSufficientNativeBalance(true);
-    }
-  }, [balanceData, sendingQuantity, setHasSufficientNativeBalance]);
+  const insufficientBalance = parseFloat(sendingQuantity) > parseFloat(balanceData?.value.toString() || "0");
 
   const { data: allowance, refetch: refetchAllowance } = useReadContract({
     query: { enabled: !isNativeTransaction && chain?.id },
@@ -187,12 +168,15 @@ const DepositPaymentButton: React.FC = () => {
     <div>
       <StyledButton
         isLoading={isSending}
-        disabled={isSending || !!error}
-        tooltip={error}
+        disabled={isSending || insufficientBalance}
         text={isNativeTransaction || isApproved ? "Deposit the Payment" : "Approve Token"}
         onClick={isNativeTransaction || isApproved ? handleCreateTransaction : handleApproveToken}
       />
-      {error ? <ErrorMessage><ClosedCircleIcon /> {error}</ErrorMessage> : null}
+      {insufficientBalance && (
+        <ErrorButtonMessage>
+          <ClosedCircleIcon /> Insufficient balance
+        </ErrorButtonMessage>
+      )}
     </div>
   );
 };