Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continuing Discussion #2

Open
bhardin opened this issue Sep 17, 2013 · 2 comments
Open

Continuing Discussion #2

bhardin opened this issue Sep 17, 2013 · 2 comments

Comments

@bhardin
Copy link
Contributor

bhardin commented Sep 17, 2013

Coming from:

kissmetrics/KISSmetrics#22
@bhardin bhardin mentioned this issue Sep 17, 2013
Closed
@Gargron
Copy link
Contributor

Gargron commented Sep 17, 2013

Alright, I've got to fill the test stubs now. There is also another thing that concerns me, and that is that the third argument in http_build_query (in the Client::submit method) is only available up from PHP 5.4. It would be nice to maybe backport it so that 5.3 folks can use the lib too.

@bhardin
Copy link
Contributor Author

bhardin commented Sep 17, 2013

However you would like to do it is fine by me.

@Gargon Could you push a basic test? I want to make sure that travis is working correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bhardin @Gargron