Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requirements handling #1

Open
visze opened this issue Mar 26, 2020 · 2 comments
Open

requirements handling #1

visze opened this issue Mar 26, 2020 · 2 comments
Assignees
@sroener
Labels
documentation Improvements or additions to documentation

Comments

@visze
Copy link
Contributor

visze commented Mar 26, 2020

I was wandering if pip already installs the requirements listed in the setup.py and you do not need to do the workaround with conda.
@sroener
Copy link
Collaborator

sroener commented Mar 26, 2020

The conda workaround is for when you don't want to install the package via pip, otherwise pip should install the requirements.

I should probably explicitly mention this in the README.md

@sroener sroener self-assigned this Mar 26, 2020
@sroener sroener added the documentation Improvements or additions to documentation label Mar 26, 2020
@sroener sroener closed this as completed Mar 29, 2020
@visze
Copy link
Contributor Author

visze commented Mar 30, 2020 •
edited
Loading

I think the environment.yml is not needed anymore. Maybe you can switch to a requirement file when using pypi, which make it easier with bioconda. But right now the recipe on bioconda works :-) https://bioconda.github.io/recipes/negative_training_sampler/README.html

@visze visze reopened this Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sroener sroener

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@visze @sroener