Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

results: use subcommands instead of --action= option #65

Closed
padovan opened this issue Dec 13, 2024 · 4 comments
Closed

results: use subcommands instead of --action= option #65

padovan opened this issue Dec 13, 2024 · 4 comments

Comments

@padovan
Copy link
Contributor

padovan commented Dec 13, 2024 •
edited
Loading

We want the results cmd to look like kci-dev results summary instead of kci-dev results --action=summary , but we didn't figure out yet how to do that with Python Click.

Related to #57
@aliceinwire
Copy link
Member

aliceinwire commented Dec 15, 2024 •
edited
Loading

why don't use click choice options https://click.palletsprojects.com/en/stable/options/#choice-options
choice options looks like what you need to use instead of having a 'sub sub command' and it make it more clear, as summary is not really a sub command but a choice option
choice options also appear in the help file so that is clear what are the option that can be used

@aliceinwire
Copy link
Member

I will send a draft with this

@aliceinwire
Copy link
Member

Draft: #70

@aliceinwire
Copy link
Member

fixed by #70

@padovan padovan mentioned this issue Jan 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@padovan @aliceinwire