-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaks jQuery for versions >=0.3.2 #39
Comments
I'm looking at the diff and I don't get how 0.3.1 could work but the later versions 🤔 I'm assuming you don't get any error in the console and you ran |
Yes. I was looking through the same diff and could not figure it out. The same behaviour has been observed by other members of the team when switching back-and-forth between versions of this gem. |
I'm seeing this too when running on top of Solidus, which has jquery baked in for the /admin site... @fynsta any tips if you were able to find a work around? @julienbourdeau such a cool looking tool! awesome! |
@erwin No sorry, we just rolled back to 0.3.1. and are running that one for now. |
I had luck doing this:
And then using Here is the commit that demonstrates this workaround: o19s/quepid@d1a002f#diff-8fa62161b01787efd56863c19b7e712a949073dc606415d6d8cfe319ecc689ecR61 |
I'll try to setup o19s/quepid to see if I figure out the jquery issue |
To run quepid, check out the source and it assumes you have ruby installed locally (3.3.6). it runs in docker, so ..
Go to http://localhost:3000 Log in as Go to the Judgement interface: http://localhost:3000/books/1/judge and click the buttons. To make the code work, you need to revert the change that I made to work around thigns! Let me know and I am happy to pair. |
i also think I need to work towards getting rid of rails-jquery, but I am half on sprockets and half on importmaps, and can't quite figure out how to get to propshaft and get rid of sprockets. |
We use
jQuery
via thejquery-rails
gem. Upgrading the debugbar to 0.3.2 just completely breaks the jQuery installation (via thedebugbar_head
helper where it loads the script).With this issue:
And after commenting out
= debugbar_head if Rails.env.development?
This happens no matter which file is required first.
The text was updated successfully, but these errors were encountered: