Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ggplot2 3.5.0 update breaks {ggside} #56

Closed
IndrajeetPatil opened this issue Feb 23, 2024 · 5 comments
Closed

ggplot2 3.5.0 update breaks {ggside} #56

IndrajeetPatil opened this issue Feb 23, 2024 · 5 comments
Milestone

Comments

@IndrajeetPatil
Copy link

library(ggplot2)
library(ggside)
#> Registered S3 method overwritten by 'ggside':
#>   method from   
#>   +.gg   ggplot2

df <- expand.grid(UpperCase = LETTERS, LowerCase = letters)
df$Combo_Index <- as.integer(df$UpperCase)*as.integer(df$LowerCase)

ggplot(df, aes(UpperCase, LowerCase)) +
  geom_tile(aes(fill = Combo_Index)) + 
  geom_xsideboxplot(aes(y = Combo_Index)) 
#> Error in `geom_xsideboxplot()`:
#> ! Problem while computing aesthetics.
#> ℹ Error occurred in the 2nd layer.
#> Caused by error in `scales_add_defaults()`:
#> ! could not find function "scales_add_defaults"

Created on 2024-02-23 with reprex v2.1.0

Session info
sessioninfo::session_info()
#> ─ Session info ───────────────────────────────────────────────────────────────
#>  setting  value
#>  version  R version 4.3.2 (2023-10-31)
#>  os       macOS Sonoma 14.3.1
#>  system   aarch64, darwin20
#>  ui       X11
#>  language (EN)
#>  collate  en_US.UTF-8
#>  ctype    en_US.UTF-8
#>  tz       Europe/Tallinn
#>  date     2024-02-23
#>  pandoc   3.1.9 @ /usr/local/bin/ (via rmarkdown)
#>  quarto   1.5.16 @ /usr/local/bin/quarto
#> 
#> ─ Packages ───────────────────────────────────────────────────────────────────
#>  package     * version    date (UTC) lib source
#>  cli           3.6.2      2023-12-11 [1] RSPM (R 4.3.0)
#>  colorspace    2.1-0      2023-01-23 [1] CRAN (R 4.3.0)
#>  digest        0.6.34     2024-01-11 [1] RSPM (R 4.3.0)
#>  dplyr         1.1.4      2023-11-17 [1] RSPM (R 4.3.0)
#>  evaluate      0.23       2023-11-01 [1] CRAN (R 4.3.1)
#>  fansi         1.0.6      2023-12-08 [1] RSPM (R 4.3.0)
#>  farver        2.1.1      2022-07-06 [1] CRAN (R 4.3.0)
#>  fastmap       1.1.1      2023-02-24 [1] CRAN (R 4.3.0)
#>  fs            1.6.3      2023-07-20 [1] CRAN (R 4.3.0)
#>  generics      0.1.3      2022-07-05 [1] CRAN (R 4.3.0)
#>  ggplot2     * 3.5.0      2024-02-23 [1] local
#>  ggside      * 0.2.3      2023-12-10 [1] RSPM (R 4.3.0)
#>  glue          1.7.0      2024-01-09 [1] RSPM (R 4.3.0)
#>  gtable        0.3.4      2023-08-21 [1] CRAN (R 4.3.1)
#>  htmltools     0.5.7      2023-11-03 [1] RSPM (R 4.3.0)
#>  knitr         1.45       2023-10-30 [1] CRAN (R 4.3.1)
#>  lifecycle     1.0.4      2023-11-07 [1] RSPM (R 4.3.0)
#>  magrittr      2.0.3      2022-03-30 [1] CRAN (R 4.3.0)
#>  munsell       0.5.0      2018-06-12 [1] CRAN (R 4.3.0)
#>  pillar        1.9.0      2023-03-22 [1] CRAN (R 4.3.0)
#>  pkgconfig     2.0.3      2019-09-22 [1] CRAN (R 4.3.0)
#>  purrr         1.0.2      2023-08-10 [1] CRAN (R 4.3.0)
#>  R.cache       0.16.0     2022-07-21 [1] CRAN (R 4.3.0)
#>  R.methodsS3   1.8.2      2022-06-13 [1] CRAN (R 4.3.0)
#>  R.oo          1.26.0     2024-01-24 [1] RSPM (R 4.3.0)
#>  R.utils       2.12.3     2023-11-18 [1] RSPM (R 4.3.0)
#>  R6            2.5.1      2021-08-19 [1] CRAN (R 4.3.0)
#>  reprex        2.1.0      2024-01-11 [1] RSPM (R 4.3.0)
#>  rlang         1.1.3      2024-01-10 [1] RSPM (R 4.3.0)
#>  rmarkdown     2.25       2023-09-18 [1] CRAN (R 4.3.1)
#>  rstudioapi    0.15.0     2023-07-07 [1] CRAN (R 4.3.0)
#>  scales        1.3.0      2023-11-28 [1] RSPM (R 4.3.2)
#>  sessioninfo   1.2.2.9000 2023-11-03 [1] local
#>  styler        1.10.2     2023-12-27 [1] Github (r-lib/styler@e987d7a)
#>  tibble        3.2.1      2023-03-20 [1] CRAN (R 4.3.0)
#>  tidyselect    1.2.0      2022-10-10 [1] CRAN (R 4.3.0)
#>  utf8          1.2.4      2023-10-22 [1] CRAN (R 4.3.1)
#>  vctrs         0.6.5      2023-12-01 [1] RSPM (R 4.3.0)
#>  withr         3.0.0      2024-01-16 [1] RSPM (R 4.3.0)
#>  xfun          0.42       2024-02-08 [1] RSPM (R 4.3.0)
#>  yaml          2.3.8      2023-12-11 [1] RSPM (R 4.3.0)
#> 
#>  [1] /Library/Frameworks/R.framework/Versions/4.3-arm64/Resources/library
#>  * ── Packages attached to the search path.
#> 
#> ──────────────────────────────────────────────────────────────────────────────
@mfansler
Copy link

Confirming I could recreate this. Rolling back to ggplot2 v3.4.4 works.

@jtlandis
Copy link
Owner

Hello! I have been working on a version of ggside to be compatible with ggplot2 v3.5.0 for some time. It had been mostly ready for release for a while, all tests were passing excluding those that were done with CI tools as the new version (on dev branch) depended on ggplot2 v3.5.0 explicitly and github could not download it to pass the tests... But things pass locally.

I had just saw the official release today and I will try and get any lingering tests required for CRAN passing and submitted.

@jtlandis
Copy link
Owner

The main branch should be synced now with all changes that are compatible with ggplot2 v3.5.0. I will be releasing tonight and hopefully it will be accepted by tomorrow.

@jtlandis jtlandis added this to the ggside 0.3.0 milestone Feb 26, 2024
@jtlandis
Copy link
Owner

I received notification that it has been accepted to CRAN 🥂

@IndrajeetPatil
Copy link
Author

Thanks for quickly fixing this, @jtlandis! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants