-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deal with CMP0167 - FindBoost
module has been removed
#728
Comments
FindBoost
module has been removed
I remember you did something on aligator related to this a few weeks back @jorisv ? |
Dropping support for boost < 1.70 is fine for me, as ubuntu 20.04 has 1.71. We should try to stop distributing our copy of FindBoost things, but this will require a few test, especially on the boost python side I guess |
We could start by forking jrl-cmakemodules and testing these changes on eigenpy. Perhaps some functions like |
In the CMake docs: https://cmake.org/cmake/help/latest/policy/CMP0167.html.
The TLDR is that CMake no longer provides the
FindBoost.cmake
module (which we vendor ourselves), and just delegates to the Boost libraries' includedBoostConfig.cmake
- which are provided starting Boost 1.70.Calls to
find_package(Boost)
now need to befind_package(Boost CONFIG)
.FindBoost.cmake
copy we include with jrl-cmakemodules, I think. It contains the old logic for finding Boost, and Boost itself now provides its own find module.find_package(Boost)
to function, or fix theadd_project_dependency
calls that find Boost in our downstream projects (of the top of my head: eigenpy, pinocchio).The text was updated successfully, but these errors were encountered: