New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components are re-mounted when isActive changes #38

Open

eirikurn opened this issue Feb 14, 2019 · 1 comment

eirikurn commented Feb 14, 2019 •

edited

Loading

Since they move between being direct descendants of ScrollLock, and children of SheetLock:

https://github.com/jossmac/react-scrolllock/blob/master/src/ScrollLock.js#L52

This is bad for performance and breaks state and transitions.

joebentaylor commented Apr 15, 2019

I agree, this is a huge issue and makes everything look broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment