Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package naming is incorrect #1

Open
Harrison-Miller opened this issue May 3, 2022 · 2 comments
Open

Package naming is incorrect #1

Harrison-Miller opened this issue May 3, 2022 · 2 comments

Comments

@Harrison-Miller
Copy link

Harrison-Miller commented May 3, 2022

This looks pretty neat but your package name is incorrect. So it can't be easily imported without modification.
package name should be github.com/JosephWoodward/ginerrorhandling.

Note that packages with a - don't work either: https://go.dev/blog/package-names

you can see the issue by just running:
go get github.com/JosephWoodward/gin-errorhandling

@josephwoodward
Copy link
Owner

josephwoodward commented Jul 5, 2022

@Harrison-Miller Thanks for making me aware of this. I'm relatively new to authoring packages in Go so this is welcome feedback.

I based the package name on the pattern seen in the Gin Contrib repo where most of them follow the gin- convention used here.

@brando56894
Copy link

I need to import it as "github.com/JosephWoodward/gin-errorhandling/middleware" in order to get it to work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants