eslint_d not formatting quotes (but formatting indentation)

[RolandWarburton]

Hi, I am trying to have null-ls run eslint_d so that it fixes quotes like it does using the cli.

Take the following typescript (src/foo.ts) file for example.

const a = "a"

Using this eslint config file.

module.exports = {
  'env': {
    'browser': true,
    'es2021': true
  },
  'extends': [
    'eslint:recommended',
    'plugin:@typescript-eslint/recommended'
  ],
  'parser': '@typescript-eslint/parser',
  'parserOptions': {
    'ecmaVersion': 'latest',
    'sourceType': 'module'
  },
  'plugins': [
    '@typescript-eslint',
  ],
  'rules': {
    // this rule enforces the use of single quotes
    'quotes': ['error', 'single']
  },
};

and this null-ls config.

local null_ls = require'null-ls';
local format = null_ls.builtins.formatting;
local diagnostics = null_ls.builtins.diagnostics;

local sources = {
  diagnostics.eslint_d,
}

local formatting ={
  format.eslint_d
}

null_ls.setup({
  debug = true,
  sources = sources,
  formatting = formatting
})

I get the following correct warning.

The problem is when I try to run the formatter, it doesn't fix it.

:lua vim.lsp.buf.formatting()

The problem is probably in null-ls or in the way that its calling eslint_d, this also happens for eslint.

It works when running it outside of neovim.

❯ eslint_d src/foo.ts --fix

/home/roland/Documents/projects/lint/src/foo.ts
  1:7  warning  'a' is assigned a value but never used  @typescript-eslint/no-unused-vars

✖ 1 problem (0 errors, 1 warning)
❯ cat src/foo.ts
const a = 'a';

note that eslint_d is running fine when it comes to fixing indents through null-ls, its just everything else I've tried that fails (I have tried inserting semi's and fixing quotes)

Any hints are appreciated, it's driving me crazy!

[RolandWarburton]

Here are my logs as well. this is after running the format command.

[TRACE Thu 23 Jun 2022 09:24:59 PM AEST] .../site/pack/packer/start/null-ls.nvim/lua/null-ls/rpc.lua:121: received LSP request for method shutdown
[TRACE Thu 23 Jun 2022 09:24:59 PM AEST] .../site/pack/packer/start/null-ls.nvim/lua/null-ls/rpc.lua:146: received LSP notification for method exit
[TRACE Thu 23 Jun 2022 09:25:00 PM AEST] ...te/pack/packer/start/null-ls.nvim/lua/null-ls/client.lua:106: starting null-ls client
[TRACE Thu 23 Jun 2022 09:25:00 PM AEST] .../site/pack/packer/start/null-ls.nvim/lua/null-ls/rpc.lua:121: received LSP request for method initialize
[DEBUG Thu 23 Jun 2022 09:25:00 PM AEST] ...te/pack/packer/start/null-ls.nvim/lua/null-ls/client.lua:161: unable to notify client for method textDocument/didOpen (client not active): {
  textDocument = {
    uri = "file:///home/roland/Documents/projects/lint/src/foo.ts"
  }
}
[TRACE Thu 23 Jun 2022 09:25:00 PM AEST] .../site/pack/packer/start/null-ls.nvim/lua/null-ls/rpc.lua:146: received LSP notification for method initialized
[TRACE Thu 23 Jun 2022 09:25:00 PM AEST] .../site/pack/packer/start/null-ls.nvim/lua/null-ls/rpc.lua:146: received LSP notification for method textDocument/didOpen
[TRACE Thu 23 Jun 2022 09:25:00 PM AEST] ...ack/packer/start/null-ls.nvim/lua/null-ls/generators.lua:21: running generators for method NULL_LS_DIAGNOSTICS_ON_OPEN
[DEBUG Thu 23 Jun 2022 09:25:00 PM AEST] ...rt/null-ls.nvim/lua/null-ls/helpers/command_resolver.lua:35: attempting to find local executable node_modules/.bin/eslint_d
[DEBUG Thu 23 Jun 2022 09:25:00 PM AEST] ...rt/null-ls.nvim/lua/null-ls/helpers/command_resolver.lua:41: Unable to resolve command [node_modules/.bin/eslint_d], skipping further lookups
[DEBUG Thu 23 Jun 2022 09:25:00 PM AEST] ...t/null-ls.nvim/lua/null-ls/helpers/generator_factory.lua:286: Using dynamic command for [eslint_d], got: "eslint_d"
[DEBUG Thu 23 Jun 2022 09:25:00 PM AEST] ...t/null-ls.nvim/lua/null-ls/helpers/generator_factory.lua:346: spawning command "eslint_d" at /home/roland/Documents/projects/lint with args { "-f", "json", "--stdin", "--stdin-filename", "/home/roland/Documents/projects/lint/src/foo.ts" }
[TRACE Thu 23 Jun 2022 09:25:00 PM AEST] ...t/null-ls.nvim/lua/null-ls/helpers/generator_factory.lua:217: error output: nil
[TRACE Thu 23 Jun 2022 09:25:00 PM AEST] ...t/null-ls.nvim/lua/null-ls/helpers/generator_factory.lua:218: output: [{"filePath":"/home/roland/Documents/projects/lint/src/foo.ts","messages":[{"ruleId":"@typescript-eslint/no-unused-vars","severity":1,"message":"'a' is assigned a value but never used.","line":1,"column":7,"nodeType":"Identifier","messageId":"unusedVar","endLine":1,"endColumn":8},{"ruleId":"quotes","severity":2,"message":"Strings must use singlequote.","line":1,"column":11,"nodeType":"Literal","messageId":"wrongQuotes","endLine":1,"endColumn":14,"fix":{"range":[10,13],"text":"'a'"}}],"suppressedMessages":[],"errorCount":1,"fatalErrorCount":0,"warningCount":1,"fixableErrorCount":1,"fixableWarningCount":0,"source":"const a = \"a\";\n","usedDeprecatedRules":[]}]

[TRACE Thu 23 Jun 2022 09:25:00 PM AEST] ...ck/packer/start/null-ls.nvim/lua/null-ls/diagnostics.lua:169: received diagnostics from source 1
[TRACE Thu 23 Jun 2022 09:25:00 PM AEST] ...ck/packer/start/null-ls.nvim/lua/null-ls/diagnostics.lua:170: { {
    code = "@typescript-eslint/no-unused-vars",
    col = 6,
    end_col = 7,
    end_lnum = 0,
    end_row = 1,
    lnum = 0,
    message = "'a' is assigned a value but never used.",
    row = 1,
    severity = 2,
    source = "eslint_d"
  }, {
    code = "quotes",
    col = 10,
    end_col = 13,
    end_lnum = 0,
    end_row = 1,
    lnum = 0,
    message = "Strings must use singlequote.",
    row = 1,
    severity = 1,
    source = "eslint_d"
  } }

[fitrh]

Where did you get the formatting key from?

local formatting = { -- ??
  format.eslint_d
}

null_ls.setup({
  debug = true,
  sources = sources,
  formatting = formatting -- ??
})

As far as I know, we use sources key to register our sources

local sources = {
  diagnostics.eslint_d,
  format.eslint_d
}

null_ls.setup({
  debug = true,
  sources = sources,
})

[fitrh]

Don't forget to check :NullLsInfo and make sure that you can see eslint_d formatting under Active source(s)

Active source(s)
* name: eslint_d
* filetypes: typescript | typescriptreact | javascriptreact | svelte | vue | javascript
* methods: formatting
	
* name: eslint_d
* filetypes: typescript | typescriptreact | javascriptreact | svelte | vue | javascript
* methods: diagnostics

[RolandWarburton]

Thanks! I can't remember where I got the diagnostics key from. It wouldn't have been from the docs or readme. It now works perfect and formats the quotes.

Here's a follow-up, do you know how to avoid the prompt that asks how you would like to format the file.

When running lua vim.lsp.buf.formatting() it gives me this prompt, and I would like to auto-select 1 if possible.

Select a language server:
1: null-ls
2: tsserver
Type number and <Enter> or click with the mouse (q or empty cancels):

[RolandWarburton]

FYI I have read this but I am still a bit confused.

[RolandWarburton]

Ok don't worry, this was very config specific and I got it working, I think I have a bit of understanding about the nvim 0.8 example :)

For future readers, the code in the link above is for your lsp server config, if you followed nvim-lsp's setup guide you will have an on_attach function and you pretty much just need to paste the code into the appropriate places. Sorry I cant be more specific if anyone else has this issue.