Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move fit parameters to class __init__ #1

Open
jnothman opened this issue Aug 2, 2017 · 1 comment
Open

Move fit parameters to class __init__ #1

jnothman opened this issue Aug 2, 2017 · 1 comment

Comments

@jnothman
Copy link

jnothman commented Aug 2, 2017

In the scikit-learn API, the only arguments to fit should be arrays aligned with the data samples. Other parameters should be supplied through the class constructor. This allows the parameters to be grid-searched. It will also make your API more compatible with misvm which would be useful.

@jmarrietar
Copy link
Owner

Hi @jnothman. I just read your comment. Thanks for the feedback. I have this project a little abandoned. Hope to continue with it sometime in the future and implement your suggestions. Cheers,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants