From 32a455c31a9a8f4309827aba3e50ae887269d210 Mon Sep 17 00:00:00 2001 From: Johannes Marbach Date: Wed, 8 Jan 2025 19:34:46 +0100 Subject: [PATCH] Minor typo fixes in GC docs (#204) --- docs/src/idioms/gc.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/src/idioms/gc.md b/docs/src/idioms/gc.md index b16c35ff..32a3acd5 100644 --- a/docs/src/idioms/gc.md +++ b/docs/src/idioms/gc.md @@ -29,7 +29,7 @@ The simplest route for this would be to use a [`FinalizationRegistry`](https://d Unfortunately, [this is not yet supported by hermes](https://github.com/facebook/hermes/issues/604). ([New issue](https://github.com/facebook/hermes/issues/1440)) -Instead, for every Javascript object constructor called, we call create a `DestructibleObject` in C++, that is represented in Javascript but has a [C++ destructor](https://isocpp.org/wiki/faq/dtors). +Instead, for every Javascript object constructor called, we create a `DestructibleObject` in C++, that is represented in Javascript but has a [C++ destructor](https://isocpp.org/wiki/faq/dtors). [At the end of this \[C++\] object's lifetime](https://en.cppreference.com/w/cpp/language/destructor), the destructor is called. @@ -59,4 +59,4 @@ const result = new MyObject().uniffiUse((obj) => { ### Future work -If there is any movement on[ hermes' `FinalizationRegistry` support](https://github.com/facebook/hermes/issues/1440)) we may well consider moving to this method. +If there is any movement on [hermes' `FinalizationRegistry` support](https://github.com/facebook/hermes/issues/1440), we may well consider moving to this method.