Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InMemoryLog should use a growing mechanism similar to FilePositionCache #153

Open
franz1981 opened this issue Apr 27, 2022 · 1 comment
Open
Milestone

Comments

@franz1981
Copy link
Collaborator

franz1981 commented Apr 27, 2022

FilePositionCache allow accumulating entries while appending fixed sized chunks/pages saving expensive memory copies while enlarging capacity: InMemoryLog could make use of a similar mechanism for its entries.

Given that InMemoryLog is not for production usage this is more a wish then an actual requirement, although it's pretty handy to use it to benchmark the whole raft protocol machinery without I/O

@belaban
Copy link
Member

belaban commented Apr 27, 2022

I'm all for replacing InMemoryLog with ArrayRingBuffer, as the former only needs to keep the uncommitted entries (in my experience with CounterPerf a few 100 entries) in memory. InMemoryLog should not be taken as a prod-ready impl; it was written with unit tests in mind (where perf doesn't matter)...

@belaban belaban modified the milestones: 1.0.8, 1.0.9 Apr 28, 2022
@belaban belaban modified the milestones: 1.0.9, 1.0.10 May 3, 2022
@belaban belaban modified the milestones: 1.0.10, 1.0.11 May 19, 2022
@jabolina jabolina modified the milestones: 1.0.11, 1.0.12 May 10, 2023
@jabolina jabolina modified the milestones: 1.0.12, 1.0.13 Nov 21, 2023
@jabolina jabolina modified the milestones: 1.0.13, 1.0.14 Aug 11, 2024
@jabolina jabolina modified the milestones: 1.0.14, 1.0.15 Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants