-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the BOM Recipe to Accommodate the Latest Archetype #122
Comments
We should also modify it so we switch to 2.440.x instead of 2.426.x. 🤔 Except if the recipe has already been updated. |
From what I understand is the declarative recipe openrewrite/rewrite-jenkins@30e736b that define the minimum version The "real" version is fetch here : https://github.com/openrewrite/rewrite-jenkins/blob/main/src/main/java/org/openrewrite/jenkins/Jenkins.java#L43 Basially it doesn't check the property by itself but the managed version of org.jenkins-ci.main:jenkins-core artifact (that is influenced by the |
Downstream PR openrewrite/rewrite#4404 |
Other PR related to new archetype openrewrite/rewrite-jenkins#73 will not |
Partially fixed by #512 but missing some Improvement for comment and order of property |
Fixed on latest release 1046.v7cedb_6c8df3f Some example : https://github.com/jenkinsci/metrics-plugin/pull/296/files |
What feature do you want to see added?
Current Situation
We are currently using the existing OpenRewrite BOM recipe for our plugin modernization efforts.
Question
Does this recipe cover the case of the latest Jenkins archetype?
Potential Actions
If the current recipe covers the latest archetype:
If the current recipe does not cover the latest archetype:
Create a meta-recipe that:
jenkins.baseline
propertyModify the existing recipe by:
Precedent
The OpenRewrite team has been receptive to contributions in the past. They accepted our contribution when the archetype for the Jenkinsfile changed months ago.
Next Steps
Your thoughts and feedback on this approach are welcome.
Upstream changes
No response
Are you interested in contributing this feature?
No response
The text was updated successfully, but these errors were encountered: