Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompat with Cleanroom #72

Open
kappa-maintainer opened this issue Jan 17, 2024 · 1 comment
Open

Incompat with Cleanroom #72

kappa-maintainer opened this issue Jan 17, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@kappa-maintainer
Copy link

kappa-maintainer commented Jan 17, 2024

First, this obfuscated check is not needed in Cleanroom, it should be 26 in both dev and prod
Second, HashMap.computeIfAbsent() from here throws ConcurrentModificationException if called recursively in newer java, it should be changed to a manual null check
I could patch all of them by Mixin or ASM, but it's a bad idea to patch mods that still maintaining

@jbredwards jbredwards self-assigned this Jan 17, 2024
@jbredwards jbredwards added the bug Something isn't working label Jan 17, 2024
@Xplodin
Copy link

Xplodin commented Jan 10, 2025

oh thats why my textures bug out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants