Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incompatible with geographicraft #59

Open
xemnes opened this issue Aug 11, 2023 · 1 comment
Open

incompatible with geographicraft #59

xemnes opened this issue Aug 11, 2023 · 1 comment
Assignees
Labels
bug Something isn't working incompatibility This issue relates to another mod

Comments

@xemnes
Copy link

xemnes commented Aug 11, 2023

it seems subaquatic is incompatible with geopgraphicraft, so much so that it disables most of the mod, such as climate banding (i think?), but the biggest issue is that it stops bop biomes spawning which is required for RTG.
biometweaker is an option but i prefer the fine tuning of geographicraft.

@jbredwards jbredwards self-assigned this Aug 12, 2023
@jbredwards jbredwards added bug Something isn't working incompatibility This issue relates to another mod labels Aug 12, 2023
@xemnes
Copy link
Author

xemnes commented Oct 20, 2023

update: thought id do some investigation of my own and discovered that the asm plugin 'PluginGenLayer' was the cause of the problem. commenting out the plugin and loading up the game with a modifed version of the mod fixed the problem.
i however dont know if this would cause any problems with the mod but from the comment in the code, implies its just optimization of the method 'isBiomeOceanic'.

it doesnt however fix climate control such as climate banding so need to look more into that
edit: found that GenLayerOceanBiomes.java was the culprit, climate banding works after disabling the class.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working incompatibility This issue relates to another mod
Projects
None yet
Development

No branches or pull requests

2 participants