Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better use of local indices #291

Closed
jnsbck opened this issue Mar 15, 2024 · 2 comments
Closed

better use of local indices #291

jnsbck opened this issue Mar 15, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@jnsbck
Copy link
Contributor

jnsbck commented Mar 15, 2024

(1) the function index_of_loc returns the highest index for the closest segment and the lowest for the furthest, see #30 and (2) it is multiplying with branch_ind because we had to rely on global compartment indices -- now this could be solved with local indices and then it is not necessary anymore to pass a branch_ind to the function

return branch_ind * nseg + ind_along_branch

Originally posted by @lappalainenj in #277 (comment)

Also see here

@jnsbck jnsbck added the enhancement New feature or request label Apr 3, 2024
@jnsbck jnsbck mentioned this issue Oct 10, 2024
@michaeldeistler
Copy link
Contributor

Can this be closed @jnsbck ?

@jnsbck
Copy link
Contributor Author

jnsbck commented Oct 23, 2024

Should be adressed by #447.

@jnsbck jnsbck closed this as completed Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants