Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container exits successfully even if s3 upload fails #60

Open
alexklibisz opened this issue Nov 27, 2022 · 0 comments
Open

Container exits successfully even if s3 upload fails #60

alexklibisz opened this issue Nov 27, 2022 · 0 comments

Comments

@alexklibisz
Copy link

Hi, thanks for this project. Here's an issue I recently found. If the AWS upload fails for some reason (e.g., bad credentials), the backup script still proceeds as if nothing happened.

Here's an example where I intentionally messed up the AWS credentials:

[INFO] Uploading backup to S3

Will upload to bucket "***-backups"
upload failed: ./***-2022-11-27T17-47-09.tar.gz to s3://***-backups/***-2022-11-27T17-47-09.tar.gz An error occurred (SignatureDoesNotMatch) when calling the PutObject operation: The request signature we calculated does not match the signature you provided. Check your key and signing method.
Upload finished

...

[INFO] Backup finished

Will wait for next scheduled backup

It seems to be the expected behavior should be to fail the script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant