Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest change haven't been pushed to docker hub with proper tag. #33

Open
cnnblike opened this issue May 16, 2021 · 1 comment
Open

Comments

@cnnblike
Copy link

Hi, per my investigation, latest change related to BACKUP_CUSTOM_LABEL hasn't been pushed to docker hub yet when pulled from tag latest.
You may want to add latest to the revision 2.3.0

root@58e5fb2cc2b5:~# cat backup.sh
#!/bin/bash

# Cronjobs don't inherit their env, so load from file
source env.sh

function info {
  bold="\033[1m"
  reset="\033[0m"
  echo -e "\n$bold[INFO] $1$reset\n"
}

info "Backup starting"
TIME_START="$(date +%s.%N)"
DOCKER_SOCK="/var/run/docker.sock"
if [ -S "$DOCKER_SOCK" ]; then
  TEMPFILE="$(mktemp)"
  docker ps --format "{{.ID}}" --filter "label=docker-volume-backup.stop-during-backup=true" > "$TEMPFILE"
@jareware
Copy link
Owner

Uhh, indeed. Will need to sort that out.

Regardless, you're better off with depending on an exact version than latest, so that your backups don't suddenly break when new versions are published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants