Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot build spark-sql-internals #21

Open
edmondop opened this issue Jan 5, 2025 · 4 comments
Open

Cannot build spark-sql-internals #21

edmondop opened this issue Jan 5, 2025 · 4 comments

Comments

@edmondop
Copy link

edmondop commented Jan 5, 2025

I was trying to build Spark-SQL-internals because I want to add https://github.com/orzih/mkdocs-with-pdf, however one of the requirements cannot be satisfied because it is a private github repo.

Can that requirement become optional or open-sourced?

git+https://${GH_TOKEN}@github.com/squidfunk/mkdocs-material-insiders.git

Thanks

@jaceklaskowski
Copy link
Member

Nice! I mean, it's nice that you started working on a PDF version of the book! Thank you.

Can you please replace this line with a no--insiders suffix?

git+https://github.com/squidfunk/mkdocs-material.git

Since I'm using the Insiders version of mkdocs-material theme I've got access to private features. I'm not sure how many I use, so install the regular version of mkdocs-material and LMK how it goes.

Thanks for your efforts! 🙇

@edmondop
Copy link
Author

edmondop commented Jan 5, 2025

Sure, I think the use case for learning this content with Notebook LM from Google is quite compelling, and there is no way for Google to import an entire website from a sitemap, so the only solution I found is to convert all the content in pdf and import it as a single source.

Once I get it working we might consider attaching the PDF to Github so that other people can use it to learn?

@jaceklaskowski
Copy link
Member

Ah, it's NotebookLM. Why not use https://books.japila.pl/spark-sql-internals/?

@edmondop
Copy link
Author

edmondop commented Jan 5, 2025

It doesn't traverse links. We should build at least a single page html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants