Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p8-jp-end -quote proposed when typing end #58

Open
malmontagne opened this issue Apr 17, 2024 · 2 comments
Open

p8-jp-end -quote proposed when typing end #58

malmontagne opened this issue Apr 17, 2024 · 2 comments
Labels
help wanted Extra attention is needed low priority Not currently working on this

Comments

@malmontagne
Copy link

When I'm started typing "end" the auto completion give me this only one proposition :

p8-jp-end -quote

which appear to be 」

I'm using the last release 0.5.3

@japhib
Copy link
Owner

japhib commented May 16, 2024

Hm, I see that happening as well but I'm not too sure how to fix that. When I add end as a snippet, it fails to un-indent when I type the snippet. I'll have to look at some other vscode extensions to see what they do.

@japhib japhib added help wanted Extra attention is needed low priority Not currently working on this labels May 16, 2024
@japhib
Copy link
Owner

japhib commented Oct 28, 2024

Did a bit of research on this - in the excellent Elixir language server, it looks like they provide language keywords as completion items (pico8-ls currently does not do this). end in that language is actually special cased here and uses the TextEdit return item to correctly set the indentation.

(leaving this here for myself, for next time I come back to this)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed low priority Not currently working on this
Projects
None yet
Development

No branches or pull requests

2 participants