Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shadows not working due to RenderState parameter leakage #2129

Closed
riccardobl opened this issue Oct 24, 2023 · 0 comments · Fixed by #2130
Closed

Shadows not working due to RenderState parameter leakage #2129

riccardobl opened this issue Oct 24, 2023 · 0 comments · Fixed by #2130
Labels
bug Something that is supposed to work, but doesn't. More severe than a "defect".
Milestone
v3.7.0

Comments

@riccardobl
Copy link
Member

riccardobl commented Oct 24, 2023 •
edited
Loading

According to git bisect this broke our rendering as soon as shadows are enabled.
There's an incorrect glDepthMask(false) for some of the rendered opaque geometry, I guess from the PreShadow material.
Can anyone confirm?

Originally posted by @Trass3r in #2091 (comment)
@codex128 codex128 mentioned this issue Oct 25, 2023
Merged
@stephengold stephengold mentioned this issue Oct 25, 2023
Merged
@stephengold stephengold changed the title Possible issue with negative scale and shadows renderer Shadows not working work due to material-parameter leakage Oct 25, 2023
@stephengold stephengold linked a pull request Oct 25, 2023 that will close this issue
Fix RenderState Parameters Leaking Between Renders #2130
Merged
@stephengold stephengold changed the title Shadows not working work due to material-parameter leakage Shadows not working work due to RenderState parameter leakage Oct 25, 2023
@stephengold stephengold added this to the Future Release milestone Oct 25, 2023
@stephengold stephengold added the bug Something that is supposed to work, but doesn't. More severe than a "defect". label Oct 25, 2023
@riccardobl riccardobl changed the title Shadows not working work due to RenderState parameter leakage Shadows not working due to RenderState parameter leakage Oct 26, 2023
@stephengold stephengold modified the milestones: Future Release, v3.7.0 Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something that is supposed to work, but doesn't. More severe than a "defect".
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging a pull request may close this issue.

Fix RenderState Parameters Leaking Between Renders codex128/jmonkeyengine
2 participants
@stephengold @riccardobl