Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run_plugin_tests.py tries to pass logfile_path keword-argument to logs.collect_logs() #196

Open
SwooshyCueb opened this issue Apr 25, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@SwooshyCueb
Copy link
Member

run_plugin_tests.py tries to pass a logfile_path keword-argument to logs.collect_logs():

logs.collect_logs(ctx.docker_client, ctx.irods_containers(), output_directory, logfile_path = args.extra_logs_path)

The logfile_path keyword-argument was removed from logs.collect_logs() in 6ad3b89, so this causes an exception to be thrown after the tests have been run when --extra-logs-path is passed to run_plugin_tests.py. This means the script exits before cleaning up docker containers (#193).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

1 participant