Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlighting #168

Closed
DetachHead opened this issue Dec 23, 2021 · 3 comments
Closed

Syntax highlighting #168

DetachHead opened this issue Dec 23, 2021 · 3 comments
Labels

Comments

@DetachHead
Copy link

as mentioned in #167 (comment):

Lines that cannot be interpreted as match patterns or regular expressions are simply ignored.

though that could cause lines that are intended to be an actual rule to be silently ignored. i would suggest showing an error on invalid lines (unless they start with # or // for comments)

@iorate
Copy link
Owner

iorate commented Dec 23, 2021

Good suggestion.

I think a better solution would be to introduce syntax highlighting like uBlockOrigin/uBlock-issues#1134 (comment).
uBlock Origin uses CodeMirror, which seems to work fast enough. CodeMirror looks good to me also in terms of supporting custom key bindings (including vim-style!).
However, I don't have much time right now, and I don't know much about CodeMirror, so it will take some time to introduce it.

I have changed the title of this issue.

@iorate iorate changed the title show an error on invalid lines Syntax highlighting Dec 23, 2021
@iorate iorate added the to do label Dec 23, 2021
@iorate iorate closed this as completed in 2e2fecb Dec 31, 2021
@iorate iorate removed the to do label Dec 31, 2021
@iorate
Copy link
Owner

iorate commented Dec 31, 2021

A CodeMirror-based editor was introduced. It will be relased as v7.0.0.

editor

@github-actions
Copy link

github-actions bot commented Jan 4, 2022

🎉 This issue has been resolved in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants