You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Lines that cannot be interpreted as match patterns or regular expressions are simply ignored.
though that could cause lines that are intended to be an actual rule to be silently ignored. i would suggest showing an error on invalid lines (unless they start with # or // for comments)
The text was updated successfully, but these errors were encountered:
I think a better solution would be to introduce syntax highlighting like uBlockOrigin/uBlock-issues#1134 (comment).
uBlock Origin uses CodeMirror, which seems to work fast enough. CodeMirror looks good to me also in terms of supporting custom key bindings (including vim-style!).
However, I don't have much time right now, and I don't know much about CodeMirror, so it will take some time to introduce it.
I have changed the title of this issue.
iorate
changed the title
show an error on invalid lines
Syntax highlighting
Dec 23, 2021
as mentioned in #167 (comment):
though that could cause lines that are intended to be an actual rule to be silently ignored. i would suggest showing an error on invalid lines (unless they start with
#
or//
for comments)The text was updated successfully, but these errors were encountered: