Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrapping IPM from artifact ignores requirements.txt #698

Open
isc-shuliu opened this issue Jan 9, 2025 · 2 comments
Open

Bootstrapping IPM from artifact ignores requirements.txt #698

isc-shuliu opened this issue Jan 9, 2025 · 2 comments
Assignees
Labels
bug Something isn't working prio: high
Milestone

Comments

@isc-shuliu
Copy link
Collaborator

During recent meetings with Eric (from IPE) and @isc-jili , we discovered that when loading the installer artifact of IPM 0.10.0 (e.g., zpm-0.10.0-beta.3.xml) on a fresh iris instance, the python requirements.txt is ignored, causing all import oras calls to fail.

However, manually installation from source code works fine. Namely,

do $System.OBJ.Load("/<ipm-repo-root>/preload/cls/IPM/Installer.cls","ck")
do ##class(IPM.Installer).setup("/<ipm-repo-root>/", 3)

Something in the bootstrap process is missing.

@isc-shuliu isc-shuliu added bug Something isn't working prio: high labels Jan 9, 2025
@isc-shuliu isc-shuliu added this to the Backlog milestone Jan 9, 2025
@isc-shuliu isc-shuliu self-assigned this Jan 9, 2025
@isc-shuliu isc-shuliu changed the title Loading IPM installer artifact doens't install requirements.txt (only containing oras for now) Bootstrapping IPM from artifact ignores requirements.txt Jan 9, 2025
@isc-shuliu
Copy link
Collaborator Author

The artifacts, e.g. zpm-0.10.0-beta.3.xml, do not contain any information from requirements.txt (as expected).

Unless there's a way to attach arbitrary files into the xml artifact, we may need to hard code the python dependency installation into the code if we want to keep using the .xml artifact for one-liner installation.

@isc-kiyer
Copy link
Collaborator

@isc-shuliu This got me thinking about what would happen in an environment that has no internet access. How would it install python dependencies? Could the oras python package be packaged up at time of publishing the zpm artifact? Also, unrelated note but if we are changing the artifact type from xml, perhaps also rename it to ipm?

cc @isc-tleavitt @isc-eneil @isc-jili @isc-jlechtne

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working prio: high
Projects
None yet
Development

No branches or pull requests

2 participants