Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for redirects and file type in gitdumper.sh #43

Open
alexanderadam opened this issue Jul 14, 2020 · 3 comments
Open

Check for redirects and file type in gitdumper.sh #43

alexanderadam opened this issue Jul 14, 2020 · 3 comments

Comments

@alexanderadam
Copy link

alexanderadam commented Jul 14, 2020

I tried a random example and it turned out that requests for various files (i.e. .git/packed-refs, .git/refs/wip/index/refs/heads/master, .git/refs/stash .git/refs/wip/wtree/refs/heads/master, .git/refs/remotes/origin/HEAD, .git/info/refs .git/objects/info/packs, .git/logs/refs/remotes/origin/HEAD) were affected by a HTTP rule. They were redirected to an index HTML file.
So I guess two things should be considered here:

  1. Probably not to follow redirects
  2. Definitely check whether the result is HTML.

Otherwise it will look like this:

fatal: unexpected line in .git/packed-refs: </html>?

PS: Thank you for your work!

@gehaxelt
Copy link
Member

gehaxelt commented May 5, 2021

Hey @alexanderadam and @xavior1412,
I've implemented

  • A flag to disable redirects
  • Checks for HTML documents
    on the dev branch [0].

Could you please check if that works and fixes your issues?

[0] https://github.com/internetwache/GitTools/tree/dev

@alexanderadam
Copy link
Author

I wow. I totally forgot about this issue and I don't know where this cases appeared 🙈
Should I close this issue?

@gehaxelt
Copy link
Member

gehaxelt commented May 5, 2021

Yeah, sorry for the delay on this one. I'd wait for xavior for a few days and then merge the new features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants