Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I have concerns about this change. Is it safe to use a 64-bit integer as an array index (base) on a 32-bit OS? (We still support 32-bit Windows.) We could change int to long, but long is 32 bits on Windows. If the caller could adapt to the current interface, that would be great. After all, the protection bitmap shouldn't be very long, right? If max_gpa is 8GB, the bitmap size will be 256KB. #774

Closed
shakthi2230 opened this issue Jan 21, 2025 · 1 comment
Assignees

Comments

@shakthi2230
Copy link

          I have concerns about this change. Is it safe to use a 64-bit integer as an array index (`base`) on a 32-bit OS? (We still support 32-bit Windows.) We could change `int` to `long`, but `long` is 32 bits on Windows. If the caller could adapt to the current interface, that would be great. After all, the protection bitmap shouldn't be very long, right? If max_gpa is 8GB, the bitmap size will be 256KB.

Anyway, since this change is self-contained, if it's really necessary, we should make a separate patch for it.

Originally posted by @raphaelning in intel/haxm#35 (comment)

@wangkl2 wangkl2 self-assigned this Jan 21, 2025
@wangkl2
Copy link
Member

wangkl2 commented Jan 21, 2025

@shakthi2230 Please be noted that the change mentioned in your quote has already been removed in the PR you linked, and it hadn't been modified even in the master branch. Since this issue is nothing to do with the current repo, I'll close it for now.

Welcome to starting exploring and trying our project from Intel® Extension for PyTorch* Documentation if you're interested in and post questions if any.

@wangkl2 wangkl2 closed this as completed Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants