I have concerns about this change. Is it safe to use a 64-bit integer as an array index (base
) on a 32-bit OS? (We still support 32-bit Windows.) We could change int
to long
, but long
is 32 bits on Windows. If the caller could adapt to the current interface, that would be great. After all, the protection bitmap shouldn't be very long, right? If max_gpa is 8GB, the bitmap size will be 256KB.
#774
Labels
Anyway, since this change is self-contained, if it's really necessary, we should make a separate patch for it.
Originally posted by @raphaelning in intel/haxm#35 (comment)
The text was updated successfully, but these errors were encountered: