Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more than 3 qna per context chunk #232

Open
markmc opened this issue Jul 30, 2024 · 3 comments
Open

Support more than 3 qna per context chunk #232

markmc opened this issue Jul 30, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@markmc
Copy link
Contributor

markmc commented Jul 30, 2024

From @mairin

In the current implementation of SDG, we have a knowledge YAML format that requires the inclusion of context chunks that connect to qna (questions and answers) in the file that SDG uses to generate data.

Currently, this requires having 3 qna samples per context chunk. No more, no less. If you provide less I believe it won't work, and if you provide more, any qna beyond the first 3 will be ignored.

This should be configurable and more robust in future releases if possible.

In the schema, we have minItems=3

And all of the knowledge prompts in the simple, full, and agentic pipelines only handle icl_query_{1,2,3}

@shivchander
Copy link
Member

Good feature to have in future - to convert the prompt templates we have into jinja templates and dynamically build them based on the number of icls

@nathan-weinberg nathan-weinberg added the enhancement New feature or request label Aug 20, 2024
Copy link

This issue has been automatically marked as stale because it has not had activity within 90 days. It will be automatically closed if no further activity occurs within 30 days.

@github-actions github-actions bot added the stale label Nov 19, 2024
@bbrowning
Copy link
Contributor

Still relevant, and will actually be addressed as part of an upcoming change to use Jinja templates for the prompt templates.

@github-actions github-actions bot removed the stale label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants