Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to cover schema correctness for blocks not used in upstream pipeline configs #207

Open
markmc opened this issue Jul 25, 2024 · 2 comments
Labels
testing Relates to testing

Comments

@markmc
Copy link
Contributor

markmc commented Jul 25, 2024

We hit #205 after merging #182

@bbrowning suggests we should have a

test that hands a basic yaml block definition to the schema validation for each block type just to ensure baseline expected block configuration is covered by the schemas. I know we have tox -e validate-pipelines, but that only validates the committed pipeline definitions we ship by default as opposed to validating the universe of possible and/or expected possible upstream or downstream pipeline definitions.

Copy link

This issue has been automatically marked as stale because it has not had activity within 90 days. It will be automatically closed if no further activity occurs within 30 days.

@github-actions github-actions bot added the stale label Nov 20, 2024
@bbrowning
Copy link
Contributor

We definitely need better test coverage here, and should try to tackle this as part of upcoming work that will be changing the pipeline definitions, schemas, and yaml.

@github-actions github-actions bot removed the stale label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Relates to testing
Projects
None yet
Development

No branches or pull requests

3 participants